Financial Connections: Networking Manual Entry #3677
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaidis-stripe
force-pushed
the
fc-networkingmanualentry
branch
2 times, most recently
from
84e3188
to
c1ffa0f
Compare
…save to link (#3678) ## Summary This PR: - Changes the `saveToLink` API to accept NULL selected accounts for networking manual entry. When it's NULL, we assume its networking manual entry. Context: - Financial Connections is implementing support for "networking manual entry." This feature allows a user to enter their manually entered account _once_, and then we will allow them to reuse it later through Link. - This is just one PR of many where each PR will be merged to a feature branch `fc-networkingmanualentry`. - It's expected that this PR may have some gaps or TODO's because its going to a feature branch. That being said, we still want to make sure there's no glaring logic issues/bugs. ## Testing This video shows me entering an account manually, the code offering me to "network" it (add to Link), and then after I link another real bank account, I can see both accounts: https://github.com/stripe/stripe-ios/assets/105514761/3d799607-9189-4e17-b09f-f3b446873575 This shows the end of the video where we see the extra manually entered account (note that the spacing/layout is a separate discussion from this PR): 
kgaidis-stripe
force-pushed
the
fc-networkingmanualentry
branch
from
c1ffa0f
to
e32a6d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A WIP FEATURE BRANCH FOR NETWORKING MANUAL ENTRY