Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Unexpected PaymentSheet Error in FormFactory #3460

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

yuki-stripe
Copy link
Collaborator

Summary

  • Sends an error analytic when PaymentSheet.FormFactory fails to create a form spec
  • Adds an extremely rudimentary way to test stpasserts

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-1858
https://docs.google.com/document/d/1r_DS7mDLlrwThcvX8CBUqUBRVejeVDy05Ejth8gnBGI/edit?pli=1

Testing

See unit test

Changelog

Not user facing

amk-stripe
amk-stripe previously approved these changes Apr 2, 2024
@sfriedman-stripe
Copy link
Collaborator

I've had this PR open for truly eons, but it has a good pattern for testing assertions using the CwlPreconditionTesting library if you'd rather go that route!

@yuki-stripe
Copy link
Collaborator Author

I've had this PR open for truly eons, but it has a good pattern for testing assertions using the CwlPreconditionTesting library if you'd rather go that route!

Oh yeah, we should totally do that. I'll follow up in another PR.

@yuki-stripe yuki-stripe merged commit b38ed3b into master Apr 2, 2024
2 checks passed
@yuki-stripe yuki-stripe deleted the yuki/example-error-analytic branch April 2, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants