Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to catch blank ephemeral keys in CustomerConfiguration #2517

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Apr 27, 2023

  1. Add test dependency on CwlPreconditionTesting

    CwlPreconditionTesting allows us to unit test traps (i.e. fatalError,
    assert, precondition). We currently don't have any way to test these in
    the repo, so engineers simply don't test our assertions. This will
    improve the overall state of our unit tests by encouraging testing of
    more code paths.
    
    Further reading on how CwlPreconditionTesting works: https://www.cocoawithlove.com/blog/2016/02/02/partial-functions-part-two-catching-precondition-failures.html
    sfriedman-stripe committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    a3ef8e3 View commit details
    Browse the repository at this point in the history
  2. Add validation to catch blank ephemeral keys in CustomerConfiguration

    We currently don't validate that an ephemeral key is non-empty when a
    user includes it in the `CustomerConfiguration`. This ends up giving
    users a pretty obscure error in the API response, and is difficult to
    debug today.
    
    Including this validation will catch this issue early and provide users
    a better debugging experience.
    sfriedman-stripe committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    be5bbe8 View commit details
    Browse the repository at this point in the history
  3. Add CHANGELOG entry

    sfriedman-stripe committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    9041d52 View commit details
    Browse the repository at this point in the history
  4. Typo

    Co-authored-by: Yuki <[email protected]>
    sfriedman-stripe and yuki-stripe committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    b57c748 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6a71a2e View commit details
    Browse the repository at this point in the history
  6. Fix tests

    sfriedman-stripe committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6a36eda View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Fix typos

    Co-authored-by: eurias-stripe <[email protected]>
    sfriedman-stripe and eurias-stripe committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    e9c42e0 View commit details
    Browse the repository at this point in the history