-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to catch blank ephemeral keys in CustomerConfiguration #2517
Open
sfriedman-stripe
wants to merge
7
commits into
master
Choose a base branch
from
sfriedman/validate-ephemeral-key
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 27, 2023
-
Add test dependency on CwlPreconditionTesting
CwlPreconditionTesting allows us to unit test traps (i.e. fatalError, assert, precondition). We currently don't have any way to test these in the repo, so engineers simply don't test our assertions. This will improve the overall state of our unit tests by encouraging testing of more code paths. Further reading on how CwlPreconditionTesting works: https://www.cocoawithlove.com/blog/2016/02/02/partial-functions-part-two-catching-precondition-failures.html
Configuration menu - View commit details
-
Copy full SHA for a3ef8e3 - Browse repository at this point
Copy the full SHA a3ef8e3View commit details -
Add validation to catch blank ephemeral keys in CustomerConfiguration
We currently don't validate that an ephemeral key is non-empty when a user includes it in the `CustomerConfiguration`. This ends up giving users a pretty obscure error in the API response, and is difficult to debug today. Including this validation will catch this issue early and provide users a better debugging experience.
Configuration menu - View commit details
-
Copy full SHA for be5bbe8 - Browse repository at this point
Copy the full SHA be5bbe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9041d52 - Browse repository at this point
Copy the full SHA 9041d52View commit details -
Co-authored-by: Yuki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b57c748 - Browse repository at this point
Copy the full SHA b57c748View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a71a2e - Browse repository at this point
Copy the full SHA 6a71a2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a36eda - Browse repository at this point
Copy the full SHA 6a36edaView commit details
Commits on Apr 29, 2023
-
Co-authored-by: eurias-stripe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e9c42e0 - Browse repository at this point
Copy the full SHA e9c42e0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.