Fallback to third position

stripe · Nov 25, 2024 · 3859ba3 · 3859ba3
1 parent 5bd154e
commit 3859ba3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentMethodType.swift b/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentMethodType.swift
@@ -191,10 +191,13 @@ extension PaymentSheet {
                 configuration.isEligibleForBankTab
             }
 
+            // Places the payment method type at either the index for `link`, or in the third / last position.
             func insertAtBankTabPosition(paymentMethodType: PaymentMethodType) {
                 let bankTabPosition = elementsSession.orderedPaymentMethodTypes.firstIndex(of: .link)
-                if let bankTabPosition, recommendedPaymentMethodTypes.indices.contains(bankTabPosition) {
-                    recommendedPaymentMethodTypes.insert(paymentMethodType, at: bankTabPosition)
+                let fallbackPosition = 2
+                let bankTabIndex = bankTabPosition ?? fallbackPosition
+                if recommendedPaymentMethodTypes.indices.contains(bankTabIndex) {
+                    recommendedPaymentMethodTypes.insert(paymentMethodType, at: bankTabIndex)
                 } else {
                     recommendedPaymentMethodTypes.append(paymentMethodType)
                 }

diff --git a/...PaymentSheet/StripePaymentSheetTests/PaymentSheet/PaymentSheetPaymentMethodTypeTest.swift b/...PaymentSheet/StripePaymentSheetTests/PaymentSheet/PaymentSheetPaymentMethodTypeTest.swift
@@ -467,7 +467,7 @@ class PaymentSheetPaymentMethodTypeTest: XCTestCase {
             ),
             configuration: configuration
         )
-        XCTAssertEqual(types, [.stripe(.cashApp), .stripe(.amazonPay), .stripe(.card), .stripe(.klarna), .linkCardBrand])
+        XCTAssertEqual(types, [.stripe(.cashApp), .stripe(.amazonPay), .linkCardBrand, .stripe(.card), .stripe(.klarna)])
     }
 
     func testPaymentMethodTypesLinkCardBrand_noDefaults() {