Mark ServiceNested as Obsolete #2983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update generated code for v1267 * Update generated code for v1268 * Update generated code for v1268 * Update generated code for v1268 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
NOTE: manually merged StripeClient.cs, StripeTypeRegistry.cs, and StripeException.cs from ramya/test branch to ensure codegen would succeed
* removed extra nested service methods from Checkout/Sessions/SessionService and Invoices/InvoiceService * added missing Update methods to InvoiceService.partial.cs * updated comments in v2 event files
* updated test names (due to renamed services) * corrected replacement name in Obsolete comments * Missing reference to System when using Obsolete tag * removed Obsolete from constructors that take IStripeClient (we will add this back in later if needed) * marked obsolete method with Obsolete and split them into CreditNoteService.partial.cs (to match existing pattern of service + partial service) * marked obsolete method with Obsolete and split them into SourceService.partial.cs (to match existing pattern of service + partial service) --------- Co-authored-by: Ramya Rao <[email protected]>
ramya-stripe
previously approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The ServiceNested used to contain methods that mirrored functionality from the Service base class but for nested services. These methods have been removed and ServiceNested is now effectively empty. This PR marks it for future deletion.
What?