Merge pull request #2625 from stripe/richardm-stop-mutation

Stop `FileService` from mutating its `RequestOptions` argument
stripe · Dec 21, 2022 · 84932a8 · 84932a8
2 parents 57e9822 + 450d2e9
commit 84932a8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/Stripe.net/Services/Files/FileService.cs b/src/Stripe.net/Services/Files/FileService.cs
@@ -72,6 +72,7 @@ private RequestOptions SetupRequestOptionsForFilesRequest(RequestOptions request
 
             if (requestOptions.BaseUrl == null)
             {
+                requestOptions = requestOptions.Clone();
                 requestOptions.BaseUrl = this.Client.FilesBase;
             }
 

diff --git a/src/Stripe.net/Services/_common/RequestOptions.cs b/src/Stripe.net/Services/_common/RequestOptions.cs
@@ -38,5 +38,10 @@ public class RequestOptions
         /// is only used for creating ephemeral keys, which require a specific API version.
         /// </remarks>
         internal string StripeVersion { get; set; }
+
+        internal RequestOptions Clone()
+            {
+                return (RequestOptions)this.MemberwiseClone();
+            }
     }
 }
diff --git a/src/StripeTests/Services/Files/FileServiceTest.cs b/src/StripeTests/Services/Files/FileServiceTest.cs
@@ -57,8 +57,11 @@ public class FileServiceTest : BaseStripeTest
         [Fact]
         public void Create()
         {
-            var file = this.service.Create(this.createOptions);
+            var requestOptions = new RequestOptions();
+
+            var file = this.service.Create(this.createOptions, requestOptions);
             this.AssertRequest(HttpMethod.Post, "/v1/files");
+            Assert.Null(requestOptions.BaseUrl);
             Assert.NotNull(file);
             Assert.Equal("file", file.Object);
         }