Update account item UI to support NME #8729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
added
the
work-cli
carlosmuvi-stripe
changed the title
carlosmuvi-stripe
changed the base branch from
master
to
carlosmuvi/generic-pane-responses
carlosmuvi-stripe
force-pushed
the
carlosmuvi/BANKCON-11422/support-clickable--disabled-accounts-on-linkaccoun
branch
from
f020998
to
062dae3
Compare
|
Diffuse output: APK |
carlosmuvi-stripe
requested review from
tillh-stripe
and removed request for
a team
tillh-stripe
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Are we sure about underlining the subtitles here? It looks rather jarring, and the container is already a selectable element.
| @@ -63,8 +66,8 @@ internal fun AccountItem( | |||
| networkedAccount: NetworkedAccount? = null, | |||
| ) { | |||
| val view = LocalView.current | |||
| // networked account's allowSelection takes precedence over the account's. | |||
| val selectable = networkedAccount?.allowSelection ?: account.allowSelection | |||
| val viewState = remember { getVisibilityState(account, networkedAccount) } | |||
There was a problem hiding this comment.
Suggested change
| val viewState = remember { getVisibilityState(account, networkedAccount) } | |
| val viewState = remember(account, networkedAccount) { | |
| getVisibilityState(account, networkedAccount) | |
| } |
| if (SDK_INT >= M) view.performHapticFeedback(CONTEXT_CLICK) | ||
| onAccountClicked(account) | ||
| } | ||
| .alpha(if (selectable) 1f else ContentAlpha.disabled) | ||
| // Reduce | ||
| .alpha(if (viewState == Enabled) 1f else VISUALLY_DISABLED_ALPHA) |
There was a problem hiding this comment.
Nit: We could add alpha to ViewState to simplify this.
| @@ -180,6 +197,16 @@ private fun PartnerAccount.getFormattedBalance(): String? { | |||
| } | |||
| } | |||
|
|
|||
| private enum class ViewState { | |||
There was a problem hiding this comment.
We should name this something else, as ViewState is overly broad.
| @@ -277,9 +277,18 @@ internal class LinkAccountPickerViewModel @AssistedInject constructor( | |||
| eventTracker.track(event) | |||
| } | |||
|
|
|||
| fun onAccountClick(partnerAccount: PartnerAccount) { | |||
| fun onAccountClick(partnerAccount: PartnerAccount) = viewModelScope.launch { | |||
There was a problem hiding this comment.
Doesn’t seem necessary to launch a coroutine here. Can you remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some UI and interaction changes related to the account view:
Motivation
📔 Support clickable + disabled accounts on LinkAccountPicker
🌐 BANKCON-11422
Testing
Screenshots
See generated screenshots
Changelog
No public changes, everything's behind a feature flag.