Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor I/O traits #31

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Refactor I/O traits #31

merged 6 commits into from
Feb 15, 2024

Conversation

dr-orlovsky
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (c5c120b) 56.0% compared to head (bdd35d5) 55.6%.

Files Patch % Lines
rust/src/traits.rs 11.9% 52 Missing ⚠️
rust/src/embedded.rs 27.3% 24 Missing ⚠️
rust/src/reader.rs 44.8% 16 Missing ⚠️
rust/test_helpers/src/lib.rs 0.0% 8 Missing ⚠️
rust/src/writer.rs 68.2% 7 Missing ⚠️
rust/src/test.rs 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #31     +/-   ##
========================================
- Coverage    56.0%   55.6%   -0.5%     
========================================
  Files          23      23             
  Lines        2718    2748     +30     
========================================
+ Hits         1523    1527      +4     
- Misses       1195    1221     +26     
Flag Coverage Δ
rust 55.6% <28.4%> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky marked this pull request as ready for review February 15, 2024 21:46
@dr-orlovsky dr-orlovsky merged commit b524cfc into master Feb 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant