Skip to content

Commit

Permalink
fix(kafka): add native support for aws-msk-iam-auth (#268)
Browse files Browse the repository at this point in the history
  • Loading branch information
fhussonnois committed Sep 7, 2023
1 parent 28d3374 commit 41e5140
Show file tree
Hide file tree
Showing 5 changed files with 68 additions and 15 deletions.
4 changes: 0 additions & 4 deletions jikkou-cli/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,6 @@ limitations under the License.
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
</dependency>
<dependency>
<groupId>software.amazon.msk</groupId>
<artifactId>aws-msk-iam-auth</artifactId>
</dependency>
<!-- START dependencies for Micronaut/Picocli -->
<dependency>
<groupId>io.micronaut</groupId>
Expand Down
6 changes: 6 additions & 0 deletions jikkou-extension-kafka/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ limitations under the License.
<artifactId>jikkou-extension-core</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>software.amazon.msk</groupId>
<artifactId>aws-msk-iam-auth</artifactId>
<version>1.1.9</version>

This comment has been minimized.

Copy link
@davidlanouette

davidlanouette Sep 7, 2023

NIT: the version is already specified in the parent pom (line 241/242). I don't think you need it here. (there are too many chances for them to get out of sync)

<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.jetbrains</groupId>
<artifactId>annotations</artifactId>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Args = -H:AdditionalSecurityProviders=software.amazon.msk.auth.iam.internals.ClassLoaderAwareIAMSaslClientProvider,software.amazon.msk.auth.iam.internals.ClassLoaderAwareIAMSaslClientProvider
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
[
{
"name" : "software.amazon.msk.auth.iam.IAMClientCallbackHandler",
"allDeclaredConstructors" : true,
"allPublicConstructors" : true,
"allDeclaredMethods" : true,
"allPublicMethods" : true
},
{
"name":"software.amazon.msk.auth.iam.IAMLoginModule",
"allDeclaredConstructors" : true,
"allPublicConstructors" : true,
"allDeclaredMethods" : true,
"allPublicMethods" : true
},
{
"name":"software.amazon.msk.auth.iam.internals.IAMSaslClient.ClassLoaderAwareIAMSaslClientFactory",
"allDeclaredConstructors" : true,
"allPublicConstructors" : true,
"allDeclaredMethods" : true,
"allPublicMethods" : true
},
{
"name":"software.amazon.msk.auth.iam.internals.IAMSaslClient.IAMSaslClientFactory",
"allDeclaredConstructors" : true,
"allPublicConstructors" : true,
"allDeclaredMethods" : true,
"allPublicMethods" : true
},
{
"name":"software.amazon.msk.auth.iam.internals.AuthenticationResponse",
"allDeclaredConstructors" : true,
"allPublicConstructors" : true,
"allDeclaredMethods" : true,
"allPublicMethods" : true
}
]
35 changes: 24 additions & 11 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ limitations under the License.
<name>Jikkou Project</name>

<description>
Jikkou :: A tool designed to provide an efficient and easy way to manage, automate, and provision resource configurations for Kafka
Jikkou :: A tool designed to provide an efficient and easy way to manage, automate, and provision resource
configurations for Kafka
</description>

<url>https://streamthoughts.github.io/jikkou/</url>
Expand Down Expand Up @@ -234,8 +235,8 @@ limitations under the License.
<groupId>org.jsonschema2pojo</groupId>
<artifactId>jsonschema2pojo-maven-plugin</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
</dependency>
<dependency>
<groupId>software.amazon.msk</groupId>
<artifactId>aws-msk-iam-auth</artifactId>
<version>1.1.9</version>
Expand Down Expand Up @@ -437,8 +438,8 @@ limitations under the License.
<include>src/integration-test/java/**/*.java</include>
</includes>

<importOrder /> <!-- standard import order -->
<removeUnusedImports /> <!-- self-explanatory -->
<importOrder/> <!-- standard import order -->
<removeUnusedImports/> <!-- self-explanatory -->
<!-- no need to specify files, inferred automatically, but you can if you want -->

<!-- make sure every file has the following copyright header.
Expand Down Expand Up @@ -677,18 +678,30 @@ limitations under the License.
<jikkou>
<artifacts>
<artifact>
<path>{{artifactsDir}}/{{distributionName}}-{{projectVersion}}-linux-x86_64.tar.gz</path>
<transform>artifacts/{{distributionName}}-{{projectEffectiveVersion}}-linux-x86_64.tar.gz</transform>
<path>
{{artifactsDir}}/{{distributionName}}-{{projectVersion}}-linux-x86_64.tar.gz
</path>
<transform>
artifacts/{{distributionName}}-{{projectEffectiveVersion}}-linux-x86_64.tar.gz
</transform>
<platform>linux-x86_64</platform>
</artifact>
<artifact>
<path>{{artifactsDir}}/{{distributionName}}-{{projectVersion}}-linux-x86_64.zip</path>
<transform>artifacts/{{distributionName}}-{{projectEffectiveVersion}}-linux-x86_64.zip</transform>
<path>
{{artifactsDir}}/{{distributionName}}-{{projectVersion}}-linux-x86_64.zip
</path>
<transform>
artifacts/{{distributionName}}-{{projectEffectiveVersion}}-linux-x86_64.zip
</transform>
<platform>linux-x86_64</platform>
</artifact>
<artifact>
<path>{{artifactsDir}}/{{distributionName}}-{{projectVersion}}-osx-x86_64.zip</path>
<transform>artifacts/{{distributionName}}-{{projectEffectiveVersion}}-osx-x86_64.zip</transform>
<path>
{{artifactsDir}}/{{distributionName}}-{{projectVersion}}-osx-x86_64.zip
</path>
<transform>
artifacts/{{distributionName}}-{{projectEffectiveVersion}}-osx-x86_64.zip
</transform>
<platform>osx-x86_64</platform>
</artifact>
</artifacts>
Expand Down

0 comments on commit 41e5140

Please sign in to comment.