Add validation for start block number vs first streamable block of the chain #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, please update the CHANGELOG (let's add other ones you fixed if they are still missing) |
Added checks in blocks method of Tier1 service to ensure that the requested start block number is equal to or greater than the first streamable block of the chain. This prevents errors caused by invalid block number requests.
colindickson
force-pushed
the
290-substreams-modules-initialblock-is-not-considered-as-the-chains-genesis-block
branch
from
6136c5a to
a99d89b
Compare
colindickson
deleted the
290-substreams-modules-initialblock-is-not-considered-as-the-chains-genesis-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks in blocks method of Tier1 service to ensure that the requested start block number is equal to or greater than the first streamable block of the chain. This prevents errors caused by invalid block number requests.