STREAM-1587: support base #174
Open
+42
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Yolley
commented
May 21, 2024
Yolley
commented
- support base
- optimise evm multi objects build
RolginRoman
reviewed
May 21, 2024
| res.value.events!.find((item: ethers.Event) => item.event === "ContractCreated")!.args![0], | ||
| ); | ||
| metadatas.push(metadataId); | ||
| metadataToRecipient[metadataId] = multipleStreamData.recipients[index]; |
There was a problem hiding this comment.
a falsy value wasn't added previously. How may it affect consumers of this function in this version?
Yolley
force-pushed
the
oleg/feature/STREAM-1587_base_network
branch
from
459a21c
to
7715125
Compare
RolginRoman
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.