Fix data race when closing amqp connection #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using conn.NotifyClose, this later append to a list of channels ``me.closes``, while conn.shutdown() range over this list, so when a connection is closed, ``conn.NotifyClose()`` may detect the connection closing in the same time as the ``conn.shutdown()`` call, this is done in two goroutine, which end up in data race where one appending to me.closes and the other looping over it. The fix is to move setting ``noNotify`` to True to the top of ``conn.shutdown()``, this way ``conn.NotifyClose()`` will not append to the list anymore.
|
@streadway In case tests are needed please let me know. |
|
Tests are never a bad idea and force closing connections is something that other client test suites often do, either via |
|
@imkira your PR looks more complete than this one. Any chance we can get your PR merged? |
|
@mouadino I hope so. I am waiting for @streadway but he seems to be busy lately. |
|
As mentioned before #196 will take care of fixing the issue, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using conn.NotifyClose, this later append to a list of channels
me.closes, while conn.shutdown() range over this list, so when aconnection is closed,
conn.NotifyClose()may detect the connection closingin the same time as the
conn.shutdown()call, this is done in twogoroutine, which end up in data race where one appending to me.closes
and the other looping over it.
The fix is to move setting
noNotifyto True to the top ofconn.shutdown(), this wayconn.NotifyClose()will not append to thelist anymore.