Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translator): fix HexError(OddLength) in mining.subscribe handler #851

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

nikicat
Copy link
Contributor

@nikicat nikicat commented Apr 15, 2024

This PR fixes
ERROR translator_sv2::lib::status: Error: V1Protocol(Method(ParsingMethodError((HexError(OddLength), StandardRequest(StandardRequest { id: 150166, method: "mining.subscribe", params: Array [String("bmminer/2.0.0"), String("265800001")] })))))
errors.

I'm new to Rust and made this PR with the help of ChatGPT, so I'm not sure it's fully correct. Nevertheless, it fixes the actual error in my case.

This error happens when the miner sends an odd-sized extranonce.

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 16:48:28 UTC
ProjectStratum v2 (SRI)
Branch851/merge
Testbedsv1
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6838.700 (-0.96%)7255.281 (94.26%)
client-submit-serialize-deserialize✅ (view plot)7873.600 (+0.61%)8243.962 (95.51%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8293.200 (-1.33%)8817.554 (94.05%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)888.650 (-1.08%)929.011 (95.66%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)690.150 (-0.88%)716.067 (96.38%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)251.830 (+1.68%)254.220 (99.06%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)155.980 (-0.55%)160.296 (97.31%)
client-sv1-get-submit✅ (view plot)6677.100 (+0.11%)7031.843 (94.96%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)268.960 (-3.54%)292.700 (91.89%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)734.460 (-1.62%)775.598 (94.70%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)607.250 (-1.28%)639.390 (94.97%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)204.310 (-1.24%)220.645 (92.60%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 16:48:29 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.889 (+0.88%)45.244 (99.21%)
client_sv2_handle_message_mining✅ (view plot)74.833 (+4.17%)80.680 (92.75%)
client_sv2_mining_message_submit_standard✅ (view plot)14.644 (-0.08%)14.694 (99.66%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)261.650 (-1.78%)289.225 (90.47%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)602.450 (+1.86%)619.405 (97.26%)
client_sv2_open_channel✅ (view plot)166.760 (+0.57%)172.302 (96.78%)
client_sv2_open_channel_serialize✅ (view plot)281.510 (-0.94%)294.818 (95.49%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)367.760 (-2.45%)408.692 (89.98%)
client_sv2_setup_connection✅ (view plot)167.880 (+2.48%)176.764 (94.97%)
client_sv2_setup_connection_serialize✅ (view plot)458.320 (-3.00%)497.364 (92.15%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)921.270 (-5.83%)1053.788 (87.42%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 16:48:30 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2066.000 (+1.10%)2135.927 (96.73%)✅ (view plot)470.000 (+0.14%)489.164 (96.08%)✅ (view plot)731.000 (+0.03%)760.189 (96.16%)✅ (view plot)8.000 (+22.79%)9.895 (80.85%)✅ (view plot)37.000 (+1.16%)38.935 (95.03%)
client_sv2_handle_message_mining✅ (view plot)8249.000 (+0.86%)8344.042 (98.86%)✅ (view plot)2137.000 (+0.75%)2174.337 (98.28%)✅ (view plot)3159.000 (+0.78%)3220.807 (98.08%)✅ (view plot)38.000 (-3.61%)43.990 (86.38%)✅ (view plot)140.000 (+1.09%)142.253 (98.42%)
client_sv2_mining_message_submit_standard✅ (view plot)6289.000 (+0.03%)6421.847 (97.93%)✅ (view plot)1747.000 (-0.13%)1767.032 (98.87%)✅ (view plot)2549.000 (-0.16%)2581.508 (98.74%)✅ (view plot)20.000 (+15.18%)22.785 (87.78%)✅ (view plot)104.000 (-0.20%)107.854 (96.43%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14830.000 (+0.53%)15066.918 (98.43%)✅ (view plot)4691.000 (-0.05%)4711.032 (99.57%)✅ (view plot)6750.000 (-0.07%)6781.543 (99.53%)✅ (view plot)48.000 (+1.54%)52.253 (91.86%)✅ (view plot)224.000 (+1.03%)230.921 (97.00%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27595.000 (+0.59%)27874.043 (99.00%)✅ (view plot)10542.000 (+0.02%)10560.379 (99.83%)✅ (view plot)15335.000 (-0.02%)15365.319 (99.80%)✅ (view plot)86.000 (+2.94%)88.845 (96.80%)✅ (view plot)338.000 (+1.31%)346.295 (97.60%)
client_sv2_open_channel✅ (view plot)4524.000 (+0.99%)4620.365 (97.91%)✅ (view plot)1458.000 (-0.12%)1478.227 (98.63%)✅ (view plot)2149.000 (-0.18%)2179.100 (98.62%)✅ (view plot)13.000 (+14.10%)14.807 (87.80%)✅ (view plot)66.000 (+1.78%)68.466 (96.40%)
client_sv2_open_channel_serialize✅ (view plot)14323.000 (+0.97%)14458.727 (99.06%)✅ (view plot)5061.000 (-0.03%)5081.227 (99.60%)✅ (view plot)7313.000 (-0.07%)7346.179 (99.55%)✅ (view plot)37.000 (+0.66%)41.443 (89.28%)✅ (view plot)195.000 (+2.13%)198.879 (98.05%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22807.000 (+1.00%)23019.682 (99.08%)✅ (view plot)7984.000 (+0.04%)8002.827 (99.76%)✅ (view plot)11607.000 (-0.06%)11643.453 (99.69%)✅ (view plot)77.000 (+7.72%)79.015 (97.45%)✅ (view plot)309.000 (+1.92%)315.066 (98.07%)
client_sv2_setup_connection✅ (view plot)4696.000 (-0.16%)4782.780 (98.19%)✅ (view plot)1499.000 (-0.12%)1519.227 (98.67%)✅ (view plot)2276.000 (+0.01%)2305.197 (98.73%)✅ (view plot)8.000 (-14.56%)14.331 (55.82%)✅ (view plot)68.000 (-0.04%)70.036 (97.09%)
client_sv2_setup_connection_serialize✅ (view plot)16331.000 (+0.63%)16445.793 (99.30%)✅ (view plot)5960.000 (-0.03%)5980.227 (99.66%)✅ (view plot)8651.000 (-0.06%)8684.845 (99.61%)✅ (view plot)45.000 (+2.70%)47.950 (93.85%)✅ (view plot)213.000 (+1.38%)216.313 (98.47%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35613.000 (+0.32%)35732.117 (99.67%)✅ (view plot)14811.000 (+0.02%)14829.827 (99.87%)✅ (view plot)21743.000 (-0.03%)21779.072 (99.83%)✅ (view plot)107.000 (+10.55%)109.717 (97.52%)✅ (view plot)381.000 (+0.53%)384.323 (99.14%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 16:48:30 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv1
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8367.000 (-1.08%)8551.559 (97.84%)✅ (view plot)3722.000 (-0.79%)3779.129 (98.49%)✅ (view plot)5212.000 (-0.91%)5304.613 (98.25%)✅ (view plot)8.000 (+1.54%)10.605 (75.44%)✅ (view plot)89.000 (-1.41%)92.042 (96.69%)
get_submit🚨 (view plot | view alert)96548.000 (+1.00%)95971.267 (100.60%)🚨 (view plot | view alert)60089.000 (+1.03%)59722.343 (100.61%)🚨 (view plot | view alert)86268.000 (+1.00%)85763.232 (100.59%)✅ (view plot)61.000 (+10.54%)61.132 (99.78%)🚨 (view plot | view alert)285.000 (+0.77%)284.956 (100.02%)
get_subscribe✅ (view plot)7960.000 (-0.57%)8095.089 (98.33%)✅ (view plot)2817.000 (-0.88%)2854.434 (98.69%)✅ (view plot)3930.000 (-1.01%)3989.348 (98.51%)✅ (view plot)15.000 (-5.89%)19.664 (76.28%)✅ (view plot)113.000 (-0.03%)115.170 (98.12%)
serialize_authorize✅ (view plot)12108.000 (-0.91%)12387.959 (97.74%)✅ (view plot)5293.000 (-0.56%)5350.129 (98.93%)✅ (view plot)7378.000 (-0.60%)7466.056 (98.82%)✅ (view plot)8.000 (-25.63%)13.394 (59.73%)✅ (view plot)134.000 (-1.12%)139.320 (96.18%)
serialize_deserialize_authorize✅ (view plot)24319.000 (-0.68%)24608.209 (98.82%)✅ (view plot)9874.000 (-0.36%)9960.586 (99.13%)✅ (view plot)13924.000 (-0.40%)14068.728 (98.97%)✅ (view plot)35.000 (-3.91%)41.139 (85.08%)✅ (view plot)292.000 (-1.02%)297.297 (98.22%)
serialize_deserialize_handle_authorize✅ (view plot)29970.000 (-0.62%)30266.716 (99.02%)✅ (view plot)12077.000 (-0.25%)12134.129 (99.53%)✅ (view plot)17090.000 (-0.25%)17181.476 (99.47%)✅ (view plot)56.000 (-2.53%)61.295 (91.36%)✅ (view plot)360.000 (-1.07%)366.861 (98.13%)
serialize_deserialize_handle_submit🚨 (view plot | view alert)127412.000 (+0.76%)126822.152 (100.47%)🚨 (view plot | view alert)73948.000 (+0.93%)73535.041 (100.56%)🚨 (view plot | view alert)105957.000 (+0.90%)105392.605 (100.54%)✅ (view plot)119.000 (-0.71%)128.764 (92.42%)✅ (view plot)596.000 (+0.09%)598.707 (99.55%)
serialize_deserialize_handle_subscribe✅ (view plot)27408.000 (-0.22%)27545.404 (99.50%)✅ (view plot)9619.000 (-0.26%)9656.434 (99.61%)✅ (view plot)13598.000 (-0.32%)13662.377 (99.53%)✅ (view plot)67.000 (+4.24%)69.417 (96.52%)✅ (view plot)385.000 (-0.23%)388.501 (99.10%)
serialize_deserialize_submit🚨 (view plot | view alert)115997.000 (+0.78%)115497.217 (100.43%)🚨 (view plot | view alert)68688.000 (+0.92%)68343.277 (100.50%)🚨 (view plot | view alert)98522.000 (+0.89%)98071.352 (100.46%)✅ (view plot)72.000 (+4.39%)73.899 (97.43%)✅ (view plot)489.000 (+0.07%)491.120 (99.57%)
serialize_deserialize_subscribe✅ (view plot)22801.000 (-0.42%)22969.449 (99.27%)✅ (view plot)8171.000 (-0.33%)8215.186 (99.46%)✅ (view plot)11501.000 (-0.39%)11576.454 (99.35%)✅ (view plot)41.000 (+5.13%)43.802 (93.60%)✅ (view plot)317.000 (-0.55%)320.508 (98.91%)
serialize_submit🚨 (view plot | view alert)100880.000 (+0.96%)100332.537 (100.55%)🚨 (view plot | view alert)62148.000 (+1.02%)61772.026 (100.61%)🚨 (view plot | view alert)89135.000 (+0.99%)88616.188 (100.59%)✅ (view plot)60.000 (+7.96%)60.291 (99.52%)✅ (view plot)327.000 (+0.60%)327.639 (99.80%)
serialize_subscribe✅ (view plot)11293.000 (-0.45%)11497.035 (98.23%)✅ (view plot)4164.000 (-0.60%)4201.434 (99.11%)✅ (view plot)5788.000 (-0.70%)5846.865 (98.99%)✅ (view plot)16.000 (-0.94%)18.793 (85.14%)✅ (view plot)155.000 (-0.18%)159.330 (97.28%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 17:19:04 UTC
ProjectStratum v2 (SRI)
Branch851/merge
Testbedsv1
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6911.300 (+0.05%)7256.654 (95.24%)
client-submit-serialize-deserialize✅ (view plot)7706.700 (-1.45%)8240.517 (93.52%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8317.000 (-1.06%)8817.456 (94.32%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)895.040 (-0.40%)929.011 (96.34%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)685.860 (-1.48%)716.191 (95.76%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)246.900 (-0.25%)253.859 (97.26%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)156.480 (-0.24%)160.299 (97.62%)
client-sv1-get-submit✅ (view plot)6660.400 (-0.13%)7031.308 (94.72%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)267.110 (-4.18%)292.852 (91.21%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)744.550 (-0.31%)775.548 (96.00%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)604.060 (-1.78%)639.471 (94.46%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)206.130 (-0.39%)220.671 (93.41%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 17:19:06 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2073.000 (+1.40%)2135.930 (97.05%)✅ (view plot)473.000 (+0.76%)488.998 (96.73%)✅ (view plot)733.000 (+0.29%)759.792 (96.47%)✅ (view plot)9.000 (+36.61%)10.033 (89.71%)✅ (view plot)37.000 (+1.13%)38.914 (95.08%)
client_sv2_handle_message_mining✅ (view plot)8249.000 (+0.83%)8345.425 (98.84%)✅ (view plot)2137.000 (+0.73%)2174.265 (98.29%)✅ (view plot)3159.000 (+0.76%)3220.598 (98.09%)✅ (view plot)38.000 (-3.51%)43.904 (86.55%)✅ (view plot)140.000 (+1.06%)142.277 (98.40%)
client_sv2_mining_message_submit_standard✅ (view plot)6296.000 (+0.13%)6419.975 (98.07%)✅ (view plot)1750.000 (+0.04%)1766.769 (99.05%)✅ (view plot)2551.000 (-0.08%)2580.999 (98.84%)✅ (view plot)21.000 (+20.20%)22.964 (91.45%)✅ (view plot)104.000 (-0.20%)107.790 (96.48%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14837.000 (+0.56%)15065.894 (98.48%)✅ (view plot)4694.000 (+0.01%)4710.769 (99.64%)✅ (view plot)6752.000 (-0.04%)6781.050 (99.57%)✅ (view plot)49.000 (+3.54%)52.263 (93.76%)✅ (view plot)224.000 (+0.99%)230.877 (97.02%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27602.000 (+0.60%)27876.225 (99.02%)✅ (view plot)10545.000 (+0.05%)10560.303 (99.86%)✅ (view plot)15337.000 (-0.00%)15364.858 (99.82%)✅ (view plot)87.000 (+4.01%)89.008 (97.74%)✅ (view plot)338.000 (+1.27%)346.319 (97.60%)
client_sv2_open_channel✅ (view plot)4531.000 (+1.11%)4620.854 (98.06%)✅ (view plot)1461.000 (+0.08%)1477.972 (98.85%)✅ (view plot)2151.000 (-0.09%)2178.632 (98.73%)✅ (view plot)14.000 (+22.05%)14.958 (93.59%)✅ (view plot)66.000 (+1.72%)68.466 (96.40%)
client_sv2_open_channel_serialize✅ (view plot)14330.000 (+0.99%)14463.630 (99.08%)✅ (view plot)5064.000 (+0.02%)5080.972 (99.67%)✅ (view plot)7315.000 (-0.05%)7345.660 (99.58%)✅ (view plot)38.000 (+3.28%)41.426 (91.73%)✅ (view plot)195.000 (+2.06%)199.008 (97.99%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22814.000 (+1.00%)23027.535 (99.07%)✅ (view plot)7987.000 (+0.07%)8002.766 (99.80%)✅ (view plot)11609.000 (-0.04%)11642.883 (99.71%)✅ (view plot)78.000 (+8.82%)79.450 (98.17%)✅ (view plot)309.000 (+1.86%)315.234 (98.02%)
client_sv2_setup_connection✅ (view plot)4703.000 (-0.01%)4781.489 (98.36%)✅ (view plot)1502.000 (+0.08%)1518.972 (98.88%)✅ (view plot)2278.000 (+0.10%)2304.801 (98.84%)✅ (view plot)9.000 (-3.77%)14.242 (63.19%)✅ (view plot)68.000 (-0.04%)70.003 (97.14%)
client_sv2_setup_connection_serialize✅ (view plot)16338.000 (+0.65%)16449.147 (99.32%)✅ (view plot)5963.000 (+0.02%)5979.972 (99.72%)✅ (view plot)8653.000 (-0.04%)8684.314 (99.64%)✅ (view plot)46.000 (+4.83%)48.023 (95.79%)✅ (view plot)213.000 (+1.34%)216.388 (98.43%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35620.000 (+0.33%)35736.040 (99.68%)✅ (view plot)14814.000 (+0.04%)14829.766 (99.89%)✅ (view plot)21745.000 (-0.02%)21778.518 (99.85%)✅ (view plot)108.000 (+11.21%)110.468 (97.77%)✅ (view plot)381.000 (+0.51%)384.346 (99.13%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 17:19:08 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.591 (+0.21%)45.236 (98.57%)
client_sv2_handle_message_mining✅ (view plot)72.204 (+0.49%)80.549 (89.64%)
client_sv2_mining_message_submit_standard✅ (view plot)14.654 (-0.01%)14.693 (99.73%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)264.770 (-0.59%)288.818 (91.67%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)600.370 (+1.46%)619.406 (96.93%)
client_sv2_open_channel✅ (view plot)162.470 (-1.96%)172.213 (94.34%)
client_sv2_open_channel_serialize✅ (view plot)282.390 (-0.61%)294.614 (95.85%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)375.670 (-0.35%)408.147 (92.04%)
client_sv2_setup_connection✅ (view plot)168.250 (+2.62%)176.786 (95.17%)
client_sv2_setup_connection_serialize✅ (view plot)496.890 (+5.01%)499.222 (99.53%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)971.280 (-0.70%)1052.411 (92.29%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 17:19:08 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv1
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8370.000 (-1.02%)8552.913 (97.86%)✅ (view plot)3725.000 (-0.69%)3779.584 (98.56%)✅ (view plot)5215.000 (-0.83%)5305.444 (98.30%)✅ (view plot)8.000 (+1.49%)10.565 (75.72%)✅ (view plot)89.000 (-1.37%)92.036 (96.70%)
get_submit🚨 (view plot | view alert)96551.000 (+0.98%)96129.395 (100.44%)🚨 (view plot | view alert)60092.000 (+1.00%)59823.170 (100.45%)🚨 (view plot | view alert)86271.000 (+0.97%)85901.722 (100.43%)✅ (view plot)61.000 (+10.20%)61.573 (99.07%)✅ (view plot)285.000 (+0.75%)285.129 (99.95%)
get_subscribe✅ (view plot)7959.000 (-0.57%)8093.899 (98.33%)✅ (view plot)2820.000 (-0.76%)2855.995 (98.74%)✅ (view plot)3934.000 (-0.88%)3992.063 (98.55%)✅ (view plot)14.000 (-11.85%)19.613 (71.38%)✅ (view plot)113.000 (-0.03%)115.135 (98.15%)
serialize_authorize✅ (view plot)12111.000 (-0.86%)12386.626 (97.77%)✅ (view plot)5296.000 (-0.49%)5350.584 (98.98%)✅ (view plot)7381.000 (-0.54%)7466.704 (98.85%)✅ (view plot)8.000 (-25.07%)13.456 (59.45%)✅ (view plot)134.000 (-1.09%)139.254 (96.23%)
serialize_deserialize_authorize✅ (view plot)24322.000 (-0.65%)24615.352 (98.81%)✅ (view plot)9877.000 (-0.32%)9960.216 (99.16%)✅ (view plot)13927.000 (-0.36%)14067.765 (99.00%)✅ (view plot)35.000 (-3.80%)41.050 (85.26%)✅ (view plot)292.000 (-0.99%)297.419 (98.18%)
serialize_deserialize_handle_authorize✅ (view plot)30011.000 (-0.47%)30273.011 (99.13%)✅ (view plot)12080.000 (-0.21%)12134.584 (99.55%)✅ (view plot)17091.000 (-0.24%)17181.895 (99.47%)✅ (view plot)57.000 (-0.77%)61.223 (93.10%)✅ (view plot)361.000 (-0.78%)366.912 (98.39%)
serialize_deserialize_handle_submit🚨 (view plot | view alert)127446.000 (+0.76%)126992.686 (100.36%)🚨 (view plot | view alert)73948.000 (+0.90%)73647.689 (100.41%)🚨 (view plot | view alert)105956.000 (+0.87%)105546.262 (100.39%)✅ (view plot)119.000 (-0.69%)128.601 (92.53%)✅ (view plot)597.000 (+0.25%)598.749 (99.71%)
serialize_deserialize_handle_subscribe✅ (view plot)27449.000 (-0.07%)27543.912 (99.66%)✅ (view plot)9622.000 (-0.22%)9657.995 (99.63%)✅ (view plot)13599.000 (-0.30%)13665.699 (99.51%)✅ (view plot)68.000 (+5.62%)69.620 (97.67%)✅ (view plot)386.000 (+0.03%)388.463 (99.37%)
serialize_deserialize_submit🚨 (view plot | view alert)115997.000 (+0.76%)115634.057 (100.31%)🚨 (view plot | view alert)68688.000 (+0.89%)68437.812 (100.37%)🚨 (view plot | view alert)98522.000 (+0.86%)98196.233 (100.33%)✅ (view plot)72.000 (+4.26%)74.031 (97.26%)✅ (view plot)489.000 (+0.07%)491.093 (99.57%)
serialize_deserialize_subscribe✅ (view plot)22804.000 (-0.39%)22973.084 (99.26%)✅ (view plot)8174.000 (-0.28%)8216.258 (99.49%)✅ (view plot)11504.000 (-0.35%)11578.237 (99.36%)✅ (view plot)41.000 (+4.97%)43.838 (93.53%)✅ (view plot)317.000 (-0.54%)320.541 (98.90%)
serialize_submit🚨 (view plot | view alert)100883.000 (+0.94%)100482.946 (100.40%)🚨 (view plot | view alert)62151.000 (+0.99%)61875.397 (100.45%)🚨 (view plot | view alert)89138.000 (+0.96%)88758.504 (100.43%)✅ (view plot)60.000 (+7.71%)60.613 (98.99%)✅ (view plot)327.000 (+0.58%)327.750 (99.77%)
serialize_subscribe✅ (view plot)11292.000 (-0.45%)11494.214 (98.24%)✅ (view plot)4167.000 (-0.51%)4202.995 (99.14%)✅ (view plot)5792.000 (-0.61%)5849.885 (99.01%)✅ (view plot)15.000 (-6.93%)18.750 (80.00%)✅ (view plot)155.000 (-0.17%)159.258 (97.33%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

benches/Cargo.lock Outdated Show resolved Hide resolved
protocols/Cargo.lock Outdated Show resolved Hide resolved
Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 22:26:49 UTC
ProjectStratum v2 (SRI)
Branch851/merge
Testbedsv1
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6722.000 (-2.60%)7257.561 (92.62%)
client-submit-serialize-deserialize✅ (view plot)7601.200 (-2.76%)8243.212 (92.21%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8192.500 (-2.50%)8820.111 (92.88%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)890.740 (-0.86%)928.990 (95.88%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)699.360 (+0.40%)716.249 (97.64%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)250.820 (+1.29%)254.102 (98.71%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)156.740 (-0.08%)160.305 (97.78%)
client-sv1-get-submit✅ (view plot)6527.300 (-2.06%)7030.985 (92.84%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)262.810 (-5.67%)293.323 (89.60%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)739.470 (-0.97%)775.510 (95.35%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)614.710 (-0.11%)639.434 (96.13%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)211.100 (+1.93%)220.917 (95.56%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 22:26:51 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv1
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)7893.000 (-6.48%)8661.857 (91.12%)✅ (view plot)3519.000 (-6.02%)3831.549 (91.84%)✅ (view plot)4948.000 (-5.74%)5369.322 (92.15%)✅ (view plot)8.000 (+1.45%)10.527 (75.99%)✅ (view plot)83.000 (-7.81%)93.154 (89.10%)
get_submit✅ (view plot)94705.000 (-0.93%)96191.093 (98.46%)✅ (view plot)59132.000 (-0.60%)59832.933 (98.83%)✅ (view plot)84955.000 (-0.55%)85912.413 (98.89%)✅ (view plot)46.000 (-16.49%)62.055 (74.13%)✅ (view plot)272.000 (-3.74%)287.030 (94.76%)
get_subscribe✅ (view plot)7417.000 (-7.15%)8214.563 (90.29%)✅ (view plot)2613.000 (-7.83%)2917.511 (89.56%)✅ (view plot)3667.000 (-7.41%)4070.322 (90.09%)✅ (view plot)15.000 (-5.41%)19.543 (76.75%)✅ (view plot)105.000 (-6.91%)116.329 (90.26%)
serialize_authorize✅ (view plot)11718.000 (-3.97%)12446.062 (94.15%)✅ (view plot)5090.000 (-4.24%)5402.549 (94.21%)✅ (view plot)7108.000 (-4.11%)7532.548 (94.36%)✅ (view plot)12.000 (+12.00%)13.490 (88.95%)✅ (view plot)130.000 (-3.93%)139.517 (93.18%)
serialize_deserialize_authorize✅ (view plot)24077.000 (-1.61%)24665.169 (97.62%)✅ (view plot)9671.000 (-2.34%)10000.819 (96.70%)✅ (view plot)13647.000 (-2.30%)14115.677 (96.68%)🚨 (view plot | view alert)42.000 (+14.93%)41.554 (101.07%)✅ (view plot)292.000 (-0.96%)297.505 (98.15%)
serialize_deserialize_handle_authorize✅ (view plot)29838.000 (-1.02%)30307.005 (98.45%)✅ (view plot)11874.000 (-1.86%)12186.549 (97.44%)✅ (view plot)16808.000 (-1.84%)17248.314 (97.45%)🚨 (view plot | view alert)65.000 (+12.74%)62.250 (104.42%)✅ (view plot)363.000 (-0.22%)366.854 (98.95%)
serialize_deserialize_handle_submit✅ (view plot)125475.000 (-0.77%)127070.142 (98.74%)✅ (view plot)72780.000 (-0.67%)73670.553 (98.79%)✅ (view plot)104325.000 (-0.66%)105578.929 (98.81%)✅ (view plot)107.000 (-10.43%)129.228 (82.80%)✅ (view plot)589.000 (-1.06%)599.261 (98.29%)
serialize_deserialize_handle_subscribe✅ (view plot)27213.000 (-0.90%)27577.981 (98.68%)✅ (view plot)9415.000 (-2.30%)9719.511 (96.87%)✅ (view plot)13323.000 (-2.26%)13746.270 (96.92%)✅ (view plot)69.000 (+6.95%)69.926 (98.68%)✅ (view plot)387.000 (+0.28%)388.486 (99.62%)
serialize_deserialize_submit✅ (view plot)114309.000 (-0.69%)115681.628 (98.81%)✅ (view plot)67694.000 (-0.55%)68447.122 (98.90%)✅ (view plot)97149.000 (-0.53%)98206.772 (98.92%)✅ (view plot)65.000 (-5.72%)74.046 (87.78%)✅ (view plot)481.000 (-1.53%)492.079 (97.75%)
serialize_deserialize_subscribe✅ (view plot)22436.000 (-1.95%)23061.787 (97.29%)✅ (view plot)7967.000 (-2.73%)8274.588 (96.28%)✅ (view plot)11231.000 (-2.64%)11651.739 (96.39%)✅ (view plot)43.000 (+9.77%)44.081 (97.55%)✅ (view plot)314.000 (-1.43%)321.035 (97.81%)
serialize_submit✅ (view plot)99136.000 (-0.79%)100524.806 (98.62%)✅ (view plot)61176.000 (-0.58%)61884.619 (98.85%)✅ (view plot)87796.000 (-0.54%)88769.097 (98.90%)✅ (view plot)49.000 (-11.73%)60.902 (80.46%)✅ (view plot)317.000 (-2.43%)328.766 (96.42%)
serialize_subscribe✅ (view plot)10848.000 (-4.24%)11559.150 (93.85%)✅ (view plot)3960.000 (-5.31%)4264.511 (92.86%)✅ (view plot)5523.000 (-5.09%)5929.520 (93.14%)✅ (view plot)15.000 (-6.75%)18.707 (80.18%)✅ (view plot)150.000 (-3.30%)159.469 (94.06%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 22:26:51 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.534 (+0.08%)45.225 (98.47%)
client_sv2_handle_message_mining✅ (view plot)74.552 (+3.65%)80.545 (92.56%)
client_sv2_mining_message_submit_standard✅ (view plot)14.647 (-0.06%)14.693 (99.69%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)262.140 (-1.54%)288.398 (90.90%)
client_sv2_mining_message_submit_standard_serialize_deserialize🚨 (view plot | view alert)635.080 (+7.10%)624.277 (101.73%)
client_sv2_open_channel✅ (view plot)166.360 (+0.38%)172.134 (96.65%)
client_sv2_open_channel_serialize✅ (view plot)287.560 (+1.18%)294.621 (97.60%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)369.100 (-2.03%)407.564 (90.56%)
client_sv2_setup_connection✅ (view plot)163.770 (-0.11%)176.581 (92.74%)
client_sv2_setup_connection_serialize✅ (view plot)478.300 (+1.05%)499.027 (95.85%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)974.880 (-0.32%)1051.170 (92.74%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 22:26:51 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2077.000 (+1.55%)2136.180 (97.23%)✅ (view plot)473.000 (+0.74%)488.836 (96.76%)✅ (view plot)732.000 (+0.15%)759.377 (96.39%)✅ (view plot)10.000 (+49.57%)10.287 (97.21%)✅ (view plot)37.000 (+1.09%)38.894 (95.13%)
client_sv2_handle_message_mining✅ (view plot)8257.000 (+0.91%)8347.296 (98.92%)✅ (view plot)2137.000 (+0.71%)2174.176 (98.29%)✅ (view plot)3157.000 (+0.67%)3220.245 (98.04%)✅ (view plot)40.000 (+1.52%)43.856 (91.21%)✅ (view plot)140.000 (+1.03%)142.298 (98.39%)
client_sv2_mining_message_submit_standard✅ (view plot)6288.000 (+0.01%)6417.925 (97.98%)✅ (view plot)1750.000 (+0.04%)1766.518 (99.06%)✅ (view plot)2553.000 (-0.00%)2580.562 (98.93%)✅ (view plot)19.000 (+8.48%)22.950 (82.79%)✅ (view plot)104.000 (-0.19%)107.729 (96.54%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14875.000 (+0.80%)15067.494 (98.72%)✅ (view plot)4694.000 (+0.01%)4710.518 (99.65%)✅ (view plot)6750.000 (-0.07%)6780.558 (99.55%)✅ (view plot)50.000 (+5.49%)52.355 (95.50%)✅ (view plot)225.000 (+1.40%)230.900 (97.44%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27636.000 (+0.70%)27880.802 (99.12%)✅ (view plot)10545.000 (+0.05%)10560.224 (99.86%)✅ (view plot)15336.000 (-0.01%)15364.395 (99.82%)✅ (view plot)87.000 (+3.89%)89.154 (97.58%)✅ (view plot)339.000 (+1.52%)346.412 (97.86%)
client_sv2_open_channel✅ (view plot)4527.000 (+1.00%)4620.955 (97.97%)✅ (view plot)1461.000 (+0.08%)1477.729 (98.87%)✅ (view plot)2152.000 (-0.04%)2178.208 (98.80%)✅ (view plot)13.000 (+12.90%)14.991 (86.72%)✅ (view plot)66.000 (+1.67%)68.465 (96.40%)
client_sv2_open_channel_serialize✅ (view plot)14334.000 (+0.99%)14468.349 (99.07%)✅ (view plot)5064.000 (+0.02%)5080.729 (99.67%)✅ (view plot)7314.000 (-0.06%)7345.155 (99.58%)✅ (view plot)39.000 (+5.81%)41.484 (94.01%)✅ (view plot)195.000 (+2.00%)199.121 (97.93%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22848.000 (+1.11%)23037.827 (99.18%)✅ (view plot)7987.000 (+0.07%)8002.700 (99.80%)✅ (view plot)11608.000 (-0.04%)11642.332 (99.71%)✅ (view plot)78.000 (+8.55%)79.834 (97.70%)✅ (view plot)310.000 (+2.13%)315.475 (98.26%)
client_sv2_setup_connection✅ (view plot)4703.000 (-0.01%)4780.259 (98.38%)✅ (view plot)1502.000 (+0.08%)1518.729 (98.90%)✅ (view plot)2278.000 (+0.09%)2304.423 (98.85%)✅ (view plot)9.000 (-3.67%)14.157 (63.57%)✅ (view plot)68.000 (-0.04%)69.972 (97.18%)
client_sv2_setup_connection_serialize✅ (view plot)16342.000 (+0.66%)16452.477 (99.33%)✅ (view plot)5963.000 (+0.02%)5979.729 (99.72%)✅ (view plot)8652.000 (-0.05%)8683.796 (99.63%)✅ (view plot)47.000 (+6.89%)48.196 (97.52%)✅ (view plot)213.000 (+1.30%)216.454 (98.40%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35654.000 (+0.41%)35742.945 (99.75%)✅ (view plot)14814.000 (+0.04%)14829.700 (99.89%)✅ (view plot)21744.000 (-0.03%)21777.986 (99.84%)✅ (view plot)108.000 (+10.85%)111.129 (97.18%)✅ (view plot)382.000 (+0.75%)384.452 (99.36%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 22:36:31 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.689 (+0.41%)45.223 (98.82%)
client_sv2_handle_message_mining✅ (view plot)74.706 (+3.75%)80.547 (92.75%)
client_sv2_mining_message_submit_standard✅ (view plot)14.659 (+0.02%)14.692 (99.77%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)259.070 (-2.62%)288.009 (89.95%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)613.650 (+3.39%)625.220 (98.15%)
client_sv2_open_channel✅ (view plot)162.920 (-1.65%)172.036 (94.70%)
client_sv2_open_channel_serialize✅ (view plot)278.520 (-1.95%)294.499 (94.57%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)370.540 (-1.60%)407.004 (91.04%)
client_sv2_setup_connection✅ (view plot)162.490 (-0.87%)176.360 (92.14%)
client_sv2_setup_connection_serialize✅ (view plot)460.990 (-2.54%)498.663 (92.45%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)971.780 (-0.62%)1049.925 (92.56%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 22:36:32 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2081.000 (+1.70%)2136.669 (97.39%)✅ (view plot)473.000 (+0.72%)488.680 (96.79%)✅ (view plot)731.000 (+0.02%)758.950 (96.32%)🚨 (view plot | view alert)11.000 (+61.63%)10.662 (103.17%)✅ (view plot)37.000 (+1.06%)38.875 (95.18%)
client_sv2_handle_message_mining✅ (view plot)8257.000 (+0.88%)8348.942 (98.90%)✅ (view plot)2137.000 (+0.69%)2174.074 (98.29%)✅ (view plot)3157.000 (+0.65%)3219.886 (98.05%)✅ (view plot)40.000 (+1.48%)43.811 (91.30%)✅ (view plot)140.000 (+1.00%)142.315 (98.37%)
client_sv2_mining_message_submit_standard✅ (view plot)6292.000 (+0.07%)6416.087 (98.07%)✅ (view plot)1750.000 (+0.04%)1766.279 (99.08%)✅ (view plot)2552.000 (-0.04%)2580.120 (98.91%)✅ (view plot)20.000 (+13.74%)23.007 (86.93%)✅ (view plot)104.000 (-0.19%)107.671 (96.59%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14879.000 (+0.80%)15069.144 (98.74%)✅ (view plot)4694.000 (+0.01%)4710.279 (99.65%)✅ (view plot)6749.000 (-0.08%)6780.084 (99.54%)✅ (view plot)51.000 (+7.37%)52.540 (97.07%)✅ (view plot)225.000 (+1.36%)230.917 (97.44%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27640.000 (+0.70%)27885.150 (99.12%)✅ (view plot)10545.000 (+0.05%)10560.143 (99.86%)✅ (view plot)15335.000 (-0.02%)15363.934 (99.81%)✅ (view plot)88.000 (+4.94%)89.395 (98.44%)✅ (view plot)339.000 (+1.48%)346.493 (97.84%)
client_sv2_open_channel✅ (view plot)4531.000 (+1.05%)4621.271 (98.05%)✅ (view plot)1461.000 (+0.08%)1477.496 (98.88%)✅ (view plot)2151.000 (-0.08%)2177.782 (98.77%)✅ (view plot)14.000 (+20.86%)15.116 (92.62%)✅ (view plot)66.000 (+1.63%)68.462 (96.40%)
client_sv2_open_channel_serialize✅ (view plot)14338.000 (+0.99%)14472.909 (99.07%)✅ (view plot)5064.000 (+0.02%)5080.496 (99.68%)✅ (view plot)7313.000 (-0.07%)7344.666 (99.57%)✅ (view plot)40.000 (+8.27%)41.633 (96.08%)✅ (view plot)195.000 (+1.95%)199.221 (97.88%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22852.000 (+1.10%)23047.394 (99.15%)✅ (view plot)7987.000 (+0.07%)8002.632 (99.80%)✅ (view plot)11607.000 (-0.05%)11641.800 (99.70%)✅ (view plot)79.000 (+9.64%)80.301 (98.38%)✅ (view plot)310.000 (+2.07%)315.690 (98.20%)
client_sv2_setup_connection✅ (view plot)4707.000 (+0.07%)4779.205 (98.49%)✅ (view plot)1502.000 (+0.08%)1518.496 (98.91%)✅ (view plot)2277.000 (+0.05%)2304.025 (98.83%)✅ (view plot)10.000 (+6.82%)14.108 (70.88%)✅ (view plot)68.000 (-0.04%)69.941 (97.22%)
client_sv2_setup_connection_serialize✅ (view plot)16346.000 (+0.67%)16455.787 (99.33%)✅ (view plot)5963.000 (+0.02%)5979.496 (99.72%)✅ (view plot)8651.000 (-0.06%)8683.293 (99.63%)✅ (view plot)48.000 (+8.88%)48.477 (99.02%)✅ (view plot)213.000 (+1.27%)216.512 (98.38%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35658.000 (+0.41%)35749.520 (99.74%)✅ (view plot)14814.000 (+0.04%)14829.632 (99.89%)✅ (view plot)21743.000 (-0.03%)21777.477 (99.84%)✅ (view plot)109.000 (+11.51%)111.840 (97.46%)✅ (view plot)382.000 (+0.73%)384.546 (99.34%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportMon, April 15, 2024 at 22:36:32 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv1
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)7893.000 (-6.31%)8715.518 (90.56%)✅ (view plot)3519.000 (-5.86%)3854.775 (91.29%)✅ (view plot)4948.000 (-5.59%)5399.581 (91.64%)✅ (view plot)8.000 (+1.41%)10.491 (76.26%)✅ (view plot)83.000 (-7.61%)93.776 (88.51%)
get_submit✅ (view plot)94705.000 (-0.90%)96234.336 (98.41%)✅ (view plot)59132.000 (-0.58%)59839.795 (98.82%)✅ (view plot)84955.000 (-0.54%)85919.734 (98.88%)✅ (view plot)46.000 (-16.11%)62.400 (73.72%)✅ (view plot)272.000 (-3.64%)288.024 (94.44%)
get_subscribe✅ (view plot)7417.000 (-6.96%)8271.795 (89.67%)✅ (view plot)2613.000 (-7.63%)2941.337 (88.84%)✅ (view plot)3667.000 (-7.22%)4101.622 (89.40%)✅ (view plot)15.000 (-5.26%)19.476 (77.02%)✅ (view plot)105.000 (-6.74%)117.006 (89.74%)
serialize_authorize✅ (view plot)11718.000 (-3.86%)12482.789 (93.87%)✅ (view plot)5090.000 (-4.13%)5425.775 (93.81%)✅ (view plot)7108.000 (-4.00%)7563.312 (93.98%)✅ (view plot)12.000 (+11.63%)13.521 (88.75%)✅ (view plot)130.000 (-3.82%)139.706 (93.05%)
serialize_deserialize_authorize✅ (view plot)24077.000 (-1.56%)24695.619 (97.50%)✅ (view plot)9671.000 (-2.27%)10022.318 (96.49%)✅ (view plot)13647.000 (-2.24%)14143.141 (96.49%)🚨 (view plot | view alert)42.000 (+14.46%)41.987 (100.03%)✅ (view plot)292.000 (-0.93%)297.566 (98.13%)
serialize_deserialize_handle_authorize✅ (view plot)29838.000 (-0.99%)30328.691 (98.38%)✅ (view plot)11874.000 (-1.81%)12209.775 (97.25%)✅ (view plot)16808.000 (-1.79%)17279.873 (97.27%)🚨 (view plot | view alert)65.000 (+12.34%)63.066 (103.07%)✅ (view plot)363.000 (-0.21%)366.799 (98.96%)
serialize_deserialize_handle_submit✅ (view plot)125475.000 (-0.75%)127123.430 (98.70%)✅ (view plot)72780.000 (-0.65%)73687.013 (98.77%)✅ (view plot)104325.000 (-0.64%)105602.441 (98.79%)✅ (view plot)107.000 (-10.17%)129.679 (82.51%)✅ (view plot)589.000 (-1.03%)599.612 (98.23%)
serialize_deserialize_handle_subscribe✅ (view plot)27213.000 (-0.88%)27598.163 (98.60%)✅ (view plot)9415.000 (-2.24%)9743.337 (96.63%)✅ (view plot)13323.000 (-2.20%)13778.975 (96.69%)✅ (view plot)69.000 (+6.75%)70.196 (98.30%)✅ (view plot)387.000 (+0.27%)388.505 (99.61%)
serialize_deserialize_submit✅ (view plot)114309.000 (-0.67%)115715.475 (98.78%)✅ (view plot)67694.000 (-0.54%)68453.583 (98.89%)✅ (view plot)97149.000 (-0.51%)98213.860 (98.92%)✅ (view plot)65.000 (-5.57%)74.046 (87.78%)✅ (view plot)481.000 (-1.48%)492.673 (97.63%)
serialize_deserialize_subscribe✅ (view plot)22436.000 (-1.89%)23105.470 (97.10%)✅ (view plot)7967.000 (-2.66%)8298.333 (96.01%)✅ (view plot)11231.000 (-2.57%)11683.505 (96.13%)✅ (view plot)43.000 (+9.48%)44.296 (97.07%)✅ (view plot)314.000 (-1.40%)321.352 (97.71%)
serialize_submit✅ (view plot)99136.000 (-0.77%)100554.812 (98.59%)✅ (view plot)61176.000 (-0.56%)61891.056 (98.84%)✅ (view plot)87796.000 (-0.53%)88776.323 (98.90%)✅ (view plot)49.000 (-11.45%)61.110 (80.18%)✅ (view plot)317.000 (-2.36%)329.383 (96.24%)
serialize_subscribe✅ (view plot)10848.000 (-4.13%)11597.904 (93.53%)✅ (view plot)3960.000 (-5.17%)4288.337 (92.34%)✅ (view plot)5523.000 (-4.95%)5961.133 (92.65%)✅ (view plot)15.000 (-6.57%)18.665 (80.36%)✅ (view plot)150.000 (-3.21%)159.621 (93.97%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Apr 15, 2024

🐰Bencher

ReportTue, April 16, 2024 at 17:00:38 UTC
ProjectStratum v2 (SRI)
Branch851/merge
Testbedsv1
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6668.600 (-3.27%)7254.636 (91.92%)
client-submit-serialize-deserialize✅ (view plot)7609.100 (-2.52%)8244.638 (92.29%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8225.600 (-2.01%)8815.743 (93.31%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle🚨 (view plot | view alert)939.530 (+4.49%)934.185 (100.57%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)695.980 (-0.15%)717.486 (97.00%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)249.080 (+0.46%)255.506 (97.48%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)161.940 (+2.94%)162.497 (99.66%)
client-sv1-get-submit✅ (view plot)6407.500 (-3.74%)7029.559 (91.15%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)260.750 (-6.21%)294.134 (88.65%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle🚨 (view plot | view alert)811.070 (+8.29%)785.930 (103.20%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)615.740 (+0.02%)639.358 (96.31%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)209.390 (+1.17%)220.522 (94.95%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@GitGab19
Copy link
Collaborator

@nikicat some tests are failing, please fix them.
As a reference, you can have a look at this paragraph: https://github.com/stratum-mining/stratum/blob/main/CONTRIBUTING.md#contribution-workflow

Copy link
Contributor

🐰Bencher

ReportTue, April 16, 2024 at 17:00:39 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.562 (+0.13%)45.214 (98.56%)
client_sv2_handle_message_mining✅ (view plot)74.567 (+3.46%)80.538 (92.59%)
client_sv2_mining_message_submit_standard✅ (view plot)14.661 (+0.03%)14.692 (99.79%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)259.110 (-2.53%)287.631 (90.08%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)592.790 (-0.12%)624.736 (94.89%)
client_sv2_open_channel✅ (view plot)166.920 (+0.74%)171.992 (97.05%)
client_sv2_open_channel_serialize✅ (view plot)279.010 (-1.73%)294.356 (94.79%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)371.130 (-1.41%)406.469 (91.31%)
client_sv2_setup_connection✅ (view plot)165.140 (+0.73%)176.218 (93.71%)
client_sv2_setup_connection_serialize✅ (view plot)490.420 (+3.58%)499.464 (98.19%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)962.090 (-1.57%)1048.651 (91.75%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportTue, April 16, 2024 at 17:00:40 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2073.000 (+1.27%)2136.542 (97.03%)✅ (view plot)473.000 (+0.70%)488.527 (96.82%)✅ (view plot)733.000 (+0.28%)758.605 (96.62%)✅ (view plot)9.000 (+31.10%)10.739 (83.80%)✅ (view plot)37.000 (+1.03%)38.857 (95.22%)
client_sv2_handle_message_mining✅ (view plot)8249.000 (+0.76%)8349.777 (98.79%)✅ (view plot)2137.000 (+0.67%)2173.961 (98.30%)✅ (view plot)3159.000 (+0.70%)3219.640 (98.12%)✅ (view plot)38.000 (-3.50%)43.736 (86.89%)✅ (view plot)140.000 (+0.97%)142.330 (98.36%)
client_sv2_mining_message_submit_standard✅ (view plot)6296.000 (+0.13%)6414.460 (98.15%)✅ (view plot)1750.000 (+0.04%)1766.049 (99.09%)✅ (view plot)2551.000 (-0.08%)2579.677 (98.89%)✅ (view plot)21.000 (+18.81%)23.149 (90.72%)✅ (view plot)104.000 (-0.18%)107.616 (96.64%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14837.000 (+0.50%)15067.818 (98.47%)✅ (view plot)4694.000 (+0.01%)4710.049 (99.66%)✅ (view plot)6752.000 (-0.03%)6779.656 (99.59%)✅ (view plot)49.000 (+3.07%)52.534 (93.27%)✅ (view plot)224.000 (+0.89%)230.868 (97.02%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27602.000 (+0.54%)27886.149 (98.98%)✅ (view plot)10545.000 (+0.05%)10560.061 (99.86%)✅ (view plot)15337.000 (-0.00%)15363.535 (99.83%)✅ (view plot)87.000 (+3.64%)89.506 (97.20%)✅ (view plot)338.000 (+1.15%)346.493 (97.55%)
client_sv2_open_channel✅ (view plot)4531.000 (+1.03%)4621.512 (98.04%)✅ (view plot)1461.000 (+0.08%)1477.272 (98.90%)✅ (view plot)2151.000 (-0.08%)2177.375 (98.79%)✅ (view plot)14.000 (+20.19%)15.229 (91.93%)✅ (view plot)66.000 (+1.58%)68.458 (96.41%)
client_sv2_open_channel_serialize✅ (view plot)14330.000 (+0.91%)14476.285 (98.99%)✅ (view plot)5064.000 (+0.02%)5080.272 (99.68%)✅ (view plot)7315.000 (-0.04%)7344.215 (99.60%)✅ (view plot)38.000 (+2.78%)41.607 (91.33%)✅ (view plot)195.000 (+1.89%)199.310 (97.84%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22814.000 (+0.91%)23052.580 (98.97%)✅ (view plot)7987.000 (+0.07%)8002.560 (99.81%)✅ (view plot)11609.000 (-0.03%)11641.304 (99.72%)✅ (view plot)78.000 (+8.01%)80.596 (96.78%)✅ (view plot)309.000 (+1.69%)315.798 (97.85%)
client_sv2_setup_connection✅ (view plot)4703.000 (-0.01%)4778.079 (98.43%)✅ (view plot)1502.000 (+0.07%)1518.272 (98.93%)✅ (view plot)2278.000 (+0.09%)2303.679 (98.89%)✅ (view plot)9.000 (-3.76%)14.031 (64.14%)✅ (view plot)68.000 (-0.04%)69.913 (97.26%)
client_sv2_setup_connection_serialize✅ (view plot)16338.000 (+0.60%)16458.062 (99.27%)✅ (view plot)5963.000 (+0.02%)5979.272 (99.73%)✅ (view plot)8653.000 (-0.03%)8682.832 (99.66%)✅ (view plot)46.000 (+4.23%)48.515 (94.82%)✅ (view plot)213.000 (+1.23%)216.563 (98.35%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35620.000 (+0.30%)35751.951 (99.63%)✅ (view plot)14814.000 (+0.04%)14829.560 (99.90%)✅ (view plot)21745.000 (-0.02%)21776.992 (99.85%)✅ (view plot)108.000 (+10.17%)112.356 (96.12%)✅ (view plot)381.000 (+0.46%)384.552 (99.08%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportTue, April 16, 2024 at 17:00:44 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv1
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)7893.000 (-6.15%)8750.760 (90.20%)✅ (view plot)3519.000 (-5.71%)3869.827 (90.93%)✅ (view plot)4948.000 (-5.45%)5419.335 (91.30%)✅ (view plot)8.000 (+1.37%)10.456 (76.51%)✅ (view plot)83.000 (-7.42%)94.195 (88.12%)
get_submit✅ (view plot)94705.000 (-0.88%)96265.662 (98.38%)✅ (view plot)59132.000 (-0.56%)59844.469 (98.81%)✅ (view plot)84955.000 (-0.52%)85924.480 (98.87%)✅ (view plot)46.000 (-15.74%)62.651 (73.42%)✅ (view plot)272.000 (-3.55%)288.684 (94.22%)
get_subscribe✅ (view plot)7417.000 (-6.79%)8309.164 (89.26%)✅ (view plot)2613.000 (-7.44%)2956.598 (88.38%)✅ (view plot)3667.000 (-7.04%)4121.708 (88.97%)✅ (view plot)15.000 (-5.13%)19.412 (77.27%)✅ (view plot)105.000 (-6.57%)117.463 (89.39%)
serialize_authorize✅ (view plot)11718.000 (-3.76%)12508.249 (93.68%)✅ (view plot)5090.000 (-4.02%)5440.827 (93.55%)✅ (view plot)7108.000 (-3.89%)7583.358 (93.73%)✅ (view plot)12.000 (+11.28%)13.548 (88.57%)✅ (view plot)130.000 (-3.72%)139.843 (92.96%)
serialize_deserialize_authorize✅ (view plot)24077.000 (-1.52%)24716.654 (97.41%)✅ (view plot)9671.000 (-2.21%)10036.627 (96.36%)✅ (view plot)13647.000 (-2.18%)14161.765 (96.37%)✅ (view plot)42.000 (+14.01%)42.366 (99.14%)✅ (view plot)292.000 (-0.91%)297.609 (98.12%)
serialize_deserialize_handle_authorize✅ (view plot)29838.000 (-0.96%)30343.885 (98.33%)✅ (view plot)11874.000 (-1.76%)12224.827 (97.13%)✅ (view plot)16808.000 (-1.74%)17300.484 (97.15%)🚨 (view plot | view alert)65.000 (+11.96%)63.745 (101.97%)✅ (view plot)363.000 (-0.21%)366.746 (98.98%)
serialize_deserialize_handle_submit✅ (view plot)125475.000 (-0.73%)127161.798 (98.67%)✅ (view plot)72780.000 (-0.63%)73698.926 (98.75%)✅ (view plot)104325.000 (-0.63%)105619.468 (98.77%)✅ (view plot)107.000 (-9.92%)130.006 (82.30%)✅ (view plot)589.000 (-1.00%)599.864 (98.19%)
serialize_deserialize_handle_subscribe✅ (view plot)27213.000 (-0.85%)27611.974 (98.56%)✅ (view plot)9415.000 (-2.18%)9758.598 (96.48%)✅ (view plot)13323.000 (-2.14%)13799.983 (96.54%)✅ (view plot)69.000 (+6.55%)70.436 (97.96%)✅ (view plot)387.000 (+0.27%)388.523 (99.61%)
serialize_deserialize_submit✅ (view plot)114309.000 (-0.65%)115740.079 (98.76%)✅ (view plot)67694.000 (-0.52%)68457.878 (98.88%)✅ (view plot)97149.000 (-0.50%)98218.298 (98.91%)✅ (view plot)65.000 (-5.43%)74.034 (87.80%)✅ (view plot)481.000 (-1.45%)493.081 (97.55%)
serialize_deserialize_subscribe✅ (view plot)22436.000 (-1.84%)23134.158 (96.98%)✅ (view plot)7967.000 (-2.59%)8313.589 (95.83%)✅ (view plot)11231.000 (-2.50%)11704.018 (95.96%)✅ (view plot)43.000 (+9.20%)44.487 (96.66%)✅ (view plot)314.000 (-1.36%)321.575 (97.64%)
serialize_submit✅ (view plot)99136.000 (-0.74%)100576.615 (98.57%)✅ (view plot)61176.000 (-0.55%)61895.383 (98.84%)✅ (view plot)87796.000 (-0.51%)88780.974 (98.89%)✅ (view plot)49.000 (-11.17%)61.260 (79.99%)✅ (view plot)317.000 (-2.30%)329.809 (96.12%)
serialize_subscribe✅ (view plot)10848.000 (-4.02%)11624.482 (93.32%)✅ (view plot)3960.000 (-5.04%)4303.598 (92.02%)✅ (view plot)5523.000 (-4.82%)5981.410 (92.34%)✅ (view plot)15.000 (-6.41%)18.624 (80.54%)✅ (view plot)150.000 (-3.12%)159.730 (93.91%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@nikicat
Copy link
Contributor Author

nikicat commented Apr 16, 2024

@GitGab19 Hi, I've fixed rustfmt errors.
The test downstream_sv1::diff_management::test::test_diff_management is just flapping - passes or fails randomly. I suppose it's out of the scope of this PR to fix it.

@plebhash
Copy link
Collaborator

@nikicat as pointed out in RELEASE.md, we ask that all external contributions are made as PRs against dev branch.

Please change the base branch of this PR, but be mindful that a rebase might be required.

@GitGab19
Copy link
Collaborator

@nikicat haven't you added some tests?
I'm not sure if they were messed up during your last pushes. But since yesterday this PR seems different.
Can you double check it?

@Fi3
Copy link
Collaborator

Fi3 commented Apr 22, 2024

Hi @nikicat ty for the patch. Can you also add a test that fail without the patch?

@nikicat
Copy link
Contributor Author

nikicat commented Apr 22, 2024

Hi @Fi3 could you point me to a test where I can add a test case? Or confirm that I should write the test from scratch.

@Fi3
Copy link
Collaborator

Fi3 commented Apr 22, 2024

@nikicat you can add an unit test in the v1 crate writing it from scratch is ok

@nikicat nikicat force-pushed the main branch 3 times, most recently from 9965470 to bfd7b69 Compare April 24, 2024 20:01
@nikicat
Copy link
Contributor Author

nikicat commented Apr 24, 2024

@Fi3 done

@Fi3
Copy link
Collaborator

Fi3 commented Apr 25, 2024

Akn, test fails without this patch. Wait for another contributor to approve since now I don't have time for review it.

@Fi3
Copy link
Collaborator

Fi3 commented Apr 29, 2024

Also remember to bump the patch version number in the translator and in the v1 lib

@pavlenex pavlenex mentioned this pull request May 1, 2024
@pavlenex pavlenex added this to the 1.0.1 milestone May 1, 2024
@Fi3 Fi3 deleted the branch stratum-mining:dev May 3, 2024 09:37
@Fi3 Fi3 closed this May 3, 2024
@Fi3 Fi3 reopened this May 3, 2024
@Fi3
Copy link
Collaborator

Fi3 commented May 3, 2024

This PR needs to be rebased on dev

@pavlenex pavlenex removed this from the 1.0.1 milestone May 10, 2024
Copy link
Contributor

github-actions bot commented Jun 1, 2024

🐰Bencher

ReportSat, June 1, 2024 at 13:56:19 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.38 (-0.39%)45.24 (98.09%)
client_sv2_handle_message_mining✅ (view plot)75.12 (+3.06%)80.50 (93.31%)
client_sv2_mining_message_submit_standard✅ (view plot)14.62 (-0.19%)14.69 (99.54%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)259.15 (-1.92%)283.98 (91.26%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)592.90 (-0.22%)628.04 (94.41%)
client_sv2_open_channel✅ (view plot)169.54 (+2.31%)171.49 (98.87%)
client_sv2_open_channel_serialize✅ (view plot)288.18 (+1.67%)293.29 (98.26%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)373.68 (-1.23%)424.36 (88.06%)
client_sv2_setup_connection✅ (view plot)167.94 (+2.24%)175.14 (95.89%)
client_sv2_setup_connection_serialize✅ (view plot)467.31 (-1.61%)505.32 (92.48%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)949.28 (-2.15%)1,038.15 (91.44%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Jun 1, 2024

🐰Bencher

ReportSat, June 1, 2024 at 13:56:21 UTC
ProjectStratum v2 (SRI)
Branchmain
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,061.00 (+0.59%)2,126.06 (96.94%)✅ (view plot)473.00 (+0.50%)486.49 (97.23%)✅ (view plot)736.00 (+0.51%)755.60 (97.41%)✅ (view plot)6.00 (-12.15%)10.37 (57.87%)✅ (view plot)37.00 (+0.98%)38.57 (95.94%)
client_sv2_handle_message_mining✅ (view plot)8,203.00 (+0.08%)8,337.03 (98.39%)✅ (view plot)2,137.00 (+0.47%)2,171.53 (98.41%)✅ (view plot)3,163.00 (+0.59%)3,216.59 (98.33%)✅ (view plot)35.00 (-8.98%)43.67 (80.15%)✅ (view plot)139.00 (+0.11%)142.00 (97.89%)
client_sv2_mining_message_submit_standard✅ (view plot)6,246.00 (-0.46%)6,389.21 (97.76%)✅ (view plot)1,750.00 (+0.03%)1,763.31 (99.25%)✅ (view plot)2,556.00 (+0.08%)2,576.27 (99.21%)✅ (view plot)17.00 (-2.07%)22.17 (76.69%)✅ (view plot)103.00 (-0.80%)106.94 (96.32%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,829.00 (+0.34%)15,037.98 (98.61%)✅ (view plot)4,694.00 (+0.01%)4,707.31 (99.72%)✅ (view plot)6,754.00 (-0.01%)6,775.52 (99.68%)✅ (view plot)47.00 (-0.32%)51.68 (90.95%)✅ (view plot)224.00 (+0.66%)230.07 (97.36%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,522.00 (+0.16%)27,849.13 (98.83%)✅ (view plot)10,545.00 (+0.03%)10,558.67 (99.87%)✅ (view plot)15,342.00 (+0.02%)15,361.14 (99.88%)✅ (view plot)84.00 (+0.45%)89.09 (94.29%)✅ (view plot)336.00 (+0.33%)345.48 (97.26%)
client_sv2_open_channel✅ (view plot)4,527.00 (+0.73%)4,612.44 (98.15%)✅ (view plot)1,461.00 (+0.06%)1,474.58 (99.08%)✅ (view plot)2,152.00 (-0.03%)2,172.99 (99.03%)✅ (view plot)13.00 (+8.16%)15.31 (84.94%)✅ (view plot)66.00 (+1.24%)68.20 (96.78%)
client_sv2_open_channel_serialize✅ (view plot)14,254.00 (+0.23%)14,461.16 (98.57%)✅ (view plot)5,064.00 (+0.02%)5,077.58 (99.73%)✅ (view plot)7,319.00 (+0.02%)7,339.48 (99.72%)✅ (view plot)36.00 (-3.00%)41.48 (86.80%)✅ (view plot)193.00 (+0.54%)198.85 (97.06%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,704.00 (+0.27%)23,030.72 (98.58%)✅ (view plot)7,987.00 (+0.05%)8,001.24 (99.82%)✅ (view plot)11,614.00 (+0.01%)11,636.75 (99.80%)✅ (view plot)76.00 (+3.87%)81.36 (93.41%)✅ (view plot)306.00 (+0.43%)315.12 (97.11%)
client_sv2_setup_connection✅ (view plot)4,699.00 (0.00%)4,765.26 (98.61%)✅ (view plot)1,502.00 (+0.06%)1,515.58 (99.10%)✅ (view plot)2,279.00 (+0.09%)2,300.05 (99.08%)✅ (view plot)8.00 (-10.55%)13.12 (60.95%)✅ (view plot)68.00 (+0.11%)69.60 (97.70%)
client_sv2_setup_connection_serialize✅ (view plot)16,372.00 (+0.61%)16,483.97 (99.32%)✅ (view plot)5,963.00 (+0.01%)5,976.58 (99.77%)✅ (view plot)8,652.00 (-0.03%)8,677.55 (99.71%)✅ (view plot)46.00 (+3.22%)48.77 (94.32%)✅ (view plot)214.00 (+1.28%)217.21 (98.52%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,612.00 (+0.21%)35,751.50 (99.61%)✅ (view plot)14,814.00 (+0.03%)14,828.24 (99.90%)✅ (view plot)21,747.00 (-0.01%)21,772.45 (99.88%)✅ (view plot)106.00 (+6.46%)112.61 (94.13%)✅ (view plot)381.00 (+0.33%)384.44 (99.11%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@stratum-mining stratum-mining deleted a comment from github-actions bot Jun 1, 2024
@stratum-mining stratum-mining deleted a comment from github-actions bot Jun 1, 2024
@plebhash plebhash merged commit 59b00c1 into stratum-mining:dev Jun 1, 2024
13 checks passed
@plebhash plebhash mentioned this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants