Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sv2-mining-proxy lib #1252

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

sv2-mining-proxy lib #1252

wants to merge 2 commits into from

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Nov 14, 2024

resolves #1251

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.13%. Comparing base (b900d0a) to head (65812ef).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
+ Coverage   19.30%   25.13%   +5.83%     
==========================================
  Files         164       20     -144     
  Lines       10849     1134    -9715     
==========================================
- Hits         2094      285    -1809     
+ Misses       8755      849    -7906
Flag Coverage Δ
binary_codec_sv2-coverage ?
binary_serde_sv2-coverage ?
binary_sv2-coverage ?
bip32_derivation-coverage ?
buffer_sv2-coverage ?
codec_sv2-coverage ?
common_messages_sv2-coverage ?
const_sv2-coverage ?
error_handling-coverage ?
framing_sv2-coverage ?
jd_client-coverage ?
jd_server-coverage ?
job_declaration_sv2-coverage ?
key-utils-coverage ?
mining-coverage ?
mining_device-coverage ?
mining_proxy_sv2-coverage ?
noise_sv2-coverage ?
pool_sv2-coverage ?
protocols ?
roles ?
roles_logic_sv2-coverage ?
sv1-mining-device-coverage ?
sv2_ffi-coverage ?
template_distribution_sv2-coverage ?
translator_sv2-coverage ?
utils 25.13% <ø> (ø)
v1-coverage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch2024-11-14-mining-proxy-lib
Testbedsv2
🚨 5 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Lower Boundary
(Limit %)		Upper Boundary
(Limit %)
client_sv2_mining_message_submit_standard_serialize_deserializeEstimated Cycles
estimated cycles		📈 plot
🚨 alert
🚷 threshold		27,784.00
(+0.93%)		27,740.92
(100.16%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions
instructions		📈 plot
🚨 alert
🚷 threshold		10,645.00
(+0.63%)		10,640.58
(100.04%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses
accesses		📈 plot
🚨 alert
🚷 threshold		15,504.00
(+0.72%)		15,489.32
(100.09%)
client_sv2_mining_message_submit_standard_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert
🚷 threshold		90.00
(+10.62%)		89.98
(100.02%)
client_sv2_open_channel_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert
🚷 threshold		86.00
(+15.70%)		85.25
(100.88%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,137.00
(+2.12%)		2,204.61
(96.93%)		📈 view plot
🚷 view threshold		473.00
(-0.04%)		488.74
(96.78%)		📈 view plot
🚷 view threshold		732.00
(-0.50%)		757.84
(96.59%)		📈 view plot
🚷 view threshold		8.00
(+45.25%)		14.29
(55.97%)		📈 view plot
🚷 view threshold		39.00
(+2.67%)		41.11
(94.86%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,178.00
(-0.34%)		8,289.63
(98.65%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,158.00
(-0.09%)		3,170.55
(99.60%)		📈 view plot
🚷 view threshold		38.00
(+6.67%)		42.32
(89.79%)		📈 view plot
🚷 view threshold		138.00
(-0.75%)		140.97
(97.89%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,323.00
(+0.71%)		6,388.49
(98.97%)		📈 view plot
🚷 view threshold		1,750.00
(-0.04%)		1,767.13
(99.03%)		📈 view plot
🚷 view threshold		2,548.00
(-0.22%)		2,576.18
(98.91%)		📈 view plot
🚷 view threshold		20.00
(+17.54%)		24.77
(80.76%)		📈 view plot
🚷 view threshold		105.00
(+0.96%)		107.00
(98.13%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,762.00
(+0.20%)		14,971.12
(98.60%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.13
(99.64%)		📈 view plot
🚷 view threshold		6,752.00
(-0.10%)		6,782.88
(99.54%)		📈 view plot
🚷 view threshold		48.00
(+10.23%)		53.58
(89.59%)		📈 view plot
🚷 view threshold		222.00
(+0.18%)		227.87
(97.42%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚨 view alert
🚷 view threshold		27,784.00
(+0.93%)		27,740.92
(100.16%)		📈 view plot
🚨 view alert
🚷 view threshold		10,645.00
(+0.63%)		10,640.58
(100.04%)		📈 view plot
🚨 view alert
🚷 view threshold		15,504.00
(+0.72%)		15,489.32
(100.09%)		📈 view plot
🚨 view alert
🚷 view threshold		90.00
(+10.62%)		89.98
(100.02%)		📈 view plot
🚷 view threshold		338.00
(+0.87%)		341.49
(98.98%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,451.00
(+1.19%)		4,618.33
(96.38%)		📈 view plot
🚷 view threshold		1,461.00
(-0.01%)		1,476.74
(98.93%)		📈 view plot
🚷 view threshold		2,156.00
(-0.16%)		2,185.44
(98.65%)		📈 view plot
🚷 view threshold		11.00
(+21.90%)		17.83
(61.69%)		📈 view plot
🚷 view threshold		64.00
(+2.09%)		68.56
(93.35%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,066.00
(+0.02%)		14,460.22
(97.27%)		📈 view plot
🚷 view threshold		5,064.00
(-0.00%)		5,079.74
(99.69%)		📈 view plot
🚷 view threshold		7,321.00
(-0.06%)		7,353.23
(99.56%)		📈 view plot
🚷 view threshold		40.00
(+13.68%)		43.53
(91.88%)		📈 view plot
🚷 view threshold		187.00
(-0.26%)		198.91
(94.01%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,896.00
(+1.02%)		22,912.64
(99.93%)		📈 view plot
🚷 view threshold		8,040.00
(+0.26%)		8,074.92
(99.57%)		📈 view plot
🚷 view threshold		11,686.00
(+0.17%)		11,755.49
(99.41%)		📈 view plot
🚨 view alert
🚷 view threshold		86.00
(+15.70%)		85.25
(100.88%)		📈 view plot
🚷 view threshold		308.00
(+1.44%)		312.12
(98.68%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,727.00
(+0.91%)		4,773.99
(99.02%)		📈 view plot
🚷 view threshold		1,502.00
(-0.01%)		1,517.74
(98.96%)		📈 view plot
🚷 view threshold		2,272.00
(-0.28%)		2,299.55
(98.80%)		📈 view plot
🚷 view threshold		15.00
(+60.80%)		15.88
(94.44%)		📈 view plot
🚷 view threshold		68.00
(+0.87%)		69.86
(97.33%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,198.00
(+0.14%)		16,473.16
(98.33%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,978.74
(99.74%)		📈 view plot
🚷 view threshold		8,658.00
(-0.06%)		8,692.83
(99.60%)		📈 view plot
🚷 view threshold		45.00
(+12.35%)		53.75
(83.71%)		📈 view plot
🚷 view threshold		209.00
(+0.05%)		216.67
(96.46%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,738.00
(+0.53%)		35,750.37
(99.97%)		📈 view plot
🚷 view threshold		14,888.00
(+0.27%)		14,905.91
(99.88%)		📈 view plot
🚷 view threshold		21,878.00
(+0.31%)		21,916.69
(99.82%)		📈 view plot
🚷 view threshold		98.00
(+5.40%)		114.57
(85.54%)		📈 view plot
🚷 view threshold		382.00
(+0.71%)		384.81
(99.27%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch2024-11-14-mining-proxy-lib
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,570.20
(-2.57%)		7,851.56
(83.68%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,593.10
(-0.96%)		8,820.18
(86.09%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,184.10
(-0.61%)		9,337.14
(87.65%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		890.96
(+0.88%)		1,002.76
(88.85%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		676.99
(-0.49%)		808.28
(83.76%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		245.44
(-1.01%)		265.37
(92.49%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		156.48
(-0.62%)		164.21
(95.29%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,432.50
(-1.39%)		7,707.98
(83.45%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		278.74
(-0.04%)		309.81
(89.97%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		727.39
(-2.08%)		878.27
(82.82%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		598.58
(-1.05%)		697.13
(85.86%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		204.48
(-1.12%)		227.09
(90.04%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch2024-11-14-mining-proxy-lib
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,391.00
(-0.76%)		8,831.12
(95.02%)		📈 view plot
🚷 view threshold		3,689.00
(-1.56%)		3,892.26
(94.78%)		📈 view plot
🚷 view threshold		5,156.00
(-1.89%)		5,461.67
(94.40%)		📈 view plot
🚷 view threshold		10.00
(+39.43%)		12.88
(77.66%)		📈 view plot
🚷 view threshold		91.00
(+0.66%)		96.20
(94.60%)
get_submit📈 view plot
🚷 view threshold		95,449.00
(+0.01%)		96,156.89
(99.26%)		📈 view plot
🚷 view threshold		59,346.00
(-0.21%)		59,819.08
(99.21%)		📈 view plot
🚷 view threshold		85,219.00
(-0.23%)		85,920.46
(99.18%)		📈 view plot
🚷 view threshold		44.00
(-2.91%)		65.24
(67.44%)		📈 view plot
🚷 view threshold		286.00
(+2.19%)		289.49
(98.79%)
get_subscribe📈 view plot
🚷 view threshold		7,872.00
(-1.77%)		8,387.46
(93.85%)		📈 view plot
🚷 view threshold		2,765.00
(-2.42%)		2,971.86
(93.04%)		📈 view plot
🚷 view threshold		3,847.00
(-2.88%)		4,154.24
(92.60%)		📈 view plot
🚷 view threshold		14.00
(+16.59%)		20.75
(67.46%)		📈 view plot
🚷 view threshold		113.00
(-0.95%)		120.16
(94.04%)
serialize_authorize📈 view plot
🚷 view threshold		12,214.00
(-0.48%)		12,655.24
(96.51%)		📈 view plot
🚷 view threshold		5,266.00
(-0.99%)		5,462.16
(96.41%)		📈 view plot
🚷 view threshold		7,324.00
(-1.26%)		7,623.12
(96.08%)		📈 view plot
🚷 view threshold		12.00
(+32.76%)		15.80
(75.97%)		📈 view plot
🚷 view threshold		138.00
(+0.42%)		143.69
(96.04%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,378.00
(-1.23%)		25,289.95
(96.39%)		📈 view plot
🚷 view threshold		9,838.00
(-0.53%)		10,056.39
(97.83%)		📈 view plot
🚷 view threshold		13,888.00
(-0.54%)		14,212.11
(97.72%)		📈 view plot
🚷 view threshold		33.00
(-5.10%)		44.26
(74.56%)		📈 view plot
🚷 view threshold		295.00
(-2.07%)		315.93
(93.37%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,114.00
(-0.66%)		30,799.90
(97.77%)		📈 view plot
🚷 view threshold		12,015.00
(-0.55%)		12,226.77
(98.27%)		📈 view plot
🚷 view threshold		16,999.00
(-0.64%)		17,320.80
(98.14%)		📈 view plot
🚷 view threshold		61.00
(+9.40%)		68.40
(89.18%)		📈 view plot
🚷 view threshold		366.00
(-0.91%)		382.11
(95.79%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,441.00
(-0.03%)		127,204.51
(99.40%)		📈 view plot
🚷 view threshold		73,200.00
(-0.12%)		73,700.75
(99.32%)		📈 view plot
🚷 view threshold		104,911.00
(-0.15%)		105,671.37
(99.28%)		📈 view plot
🚷 view threshold		106.00
(-1.19%)		133.89
(79.17%)		📈 view plot
🚷 view threshold		600.00
(+0.64%)		605.56
(99.08%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,498.00
(-1.17%)		28,652.33
(95.97%)		📈 view plot
🚷 view threshold		9,584.00
(-0.65%)		9,791.00
(97.89%)		📈 view plot
🚷 view threshold		13,543.00
(-0.75%)		13,852.09
(97.77%)		📈 view plot
🚷 view threshold		68.00
(+7.03%)		76.16
(89.29%)		📈 view plot
🚷 view threshold		389.00
(-1.78%)		417.32
(93.21%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,163.00
(-0.07%)		115,998.39
(99.28%)		📈 view plot
🚷 view threshold		68,060.00
(-0.07%)		68,515.55
(99.34%)		📈 view plot
🚷 view threshold		97,653.00
(-0.09%)		98,358.92
(99.28%)		📈 view plot
🚷 view threshold		65.00
(+3.32%)		78.84
(82.45%)		📈 view plot
🚷 view threshold		491.00
(+0.00%)		499.69
(98.26%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		22,880.00
(-1.56%)		24,080.39
(95.02%)		📈 view plot
🚷 view threshold		8,143.00
(-0.72%)		8,347.67
(97.55%)		📈 view plot
🚷 view threshold		11,465.00
(-0.77%)		11,759.57
(97.50%)		📈 view plot
🚷 view threshold		36.00
(-3.68%)		44.77
(80.42%)		📈 view plot
🚷 view threshold		321.00
(-2.32%)		349.22
(91.92%)
serialize_submit📈 view plot
🚷 view threshold		99,838.00
(-0.02%)		100,534.34
(99.31%)		📈 view plot
🚷 view threshold		61,408.00
(-0.17%)		61,864.38
(99.26%)		📈 view plot
🚷 view threshold		88,078.00
(-0.21%)		88,768.16
(99.22%)		📈 view plot
🚷 view threshold		49.00
(+4.05%)		65.65
(74.64%)		📈 view plot
🚷 view threshold		329.00
(+1.38%)		334.08
(98.48%)
serialize_subscribe📈 view plot
🚷 view threshold		11,317.00
(-0.68%)		11,767.50
(96.17%)		📈 view plot
🚷 view threshold		4,118.00
(-1.50%)		4,317.65
(95.38%)		📈 view plot
🚷 view threshold		5,707.00
(-1.91%)		6,009.75
(94.96%)		📈 view plot
🚷 view threshold		16.00
(+24.57%)		20.60
(77.68%)		📈 view plot
🚷 view threshold		158.00
(+0.31%)		164.14
(96.26%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch2024-11-14-mining-proxy-lib
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.25
(+0.78%)		47.45
(95.37%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		81.48
(+7.11%)		92.23
(88.35%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.71
(+0.33%)		14.81
(99.35%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		266.24
(-0.77%)		319.08
(83.44%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		609.82
(+2.94%)		694.00
(87.87%)
client_sv2_open_channel📈 view plot
🚷 view threshold		148.45
(+1.02%)		152.21
(97.53%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		284.80
(-0.48%)		313.47
(90.85%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		388.48
(+2.74%)		423.41
(91.75%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		159.26
(-1.48%)		181.69
(87.66%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		459.19
(-1.71%)		584.45
(78.57%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		990.98
(+2.37%)		1,091.20
(90.82%)
🐰 View full continuous benchmarking report in Bencher

@plebhash plebhash mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create lib for sv2-mining-proxy
1 participant
@jbesraa