-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize roles::test-utils::mining-device
#1175
base: main
Are you sure you want to change the base?
Modularize roles::test-utils::mining-device
#1175
Conversation
af24aba
to
c1ee625
Compare
Bencher Report
Click to view all benchmark results
|
Bencher Report
Click to view all benchmark results
|
Bencher Report
Click to view all benchmark results
|
@plebhash and @jbesraa. I have modularized the crate. I made the choice to keep all types as private as possible (most of the time things are Also, I want to add more to the |
Bencher Report
Click to view all benchmark results
|
@@ -15,7 +15,18 @@ Options: | |||
-V, --version Print version | |||
``` | |||
|
|||
Usage example: | |||
## Example | |||
1. Start a pool. The hosted example in the [`pool`](https://github.com/stratum-mining/stratum/tree/main/roles/pool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is not clear with regards to what "hosted" means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I was referring to pool-config-hosted-tp-example.toml
. I will add clarity here that this is the SRI community hosted pool server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General concept ACK.
I wouldn't move NewWorkNotifier
, NextShareOutcome
and SetupConnectionHandler
into separate files though. Each one of them is only used once either in device
or in miner
, they are private and not exported from the crate and they are fairly small. I think moving them into device
/miner
, wherever they are used, would make more sense and improve the general readability of the crate.
Addresses #1174.