-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New auth Provider 'Apple SignIn' #20
base: master
Are you sure you want to change the base?
Conversation
Thanks for this RFC ! Correct me If I'm wrong but from what I understand the only specific change is to add a POST route for the callback is that right ? |
`Purest` has not been update since 4 years, many new providers are not available (like `discord` actually). | ||
It's a sample config for Apple than want receive a Bearer access token. | ||
|
||
Maybe it will be necessary to implement other library than `Purest`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we do plan to move the Users & Permissions plugin to passport.js and split all auth providers into some kind of strapi-provider-auth-google
package (similar to upload and email). But right now there is no ETA unless @alexandrebodin has something to add.
I would imagine we would likely do this around the same time we develop the API key feature (which will be the default and Users & Permissions will be optional)
With this implementation, yes, it's the "main" change, and we need to add a generateToken method with a variable that read the private key file. My 2nd solution, implemented successfully on my website, send the I will try to make a drawing to explain different solution of implementation. Also, I agree with @derrickmehaffy, maybe it will be interesting to have this as a plugin like Thanks, |
One of those things we would love to do but lack the time at the moment, it requires a massive refactor to users-permissions and the scheduling of that is left entirely up to @sam-pires / @JabStrapi and the engineering teams. |
Is there anything left that needs to be done here that others could help with to get this added? @Lith were there changes you had locally you were planning to push? |
Thanks @Lith for your work on this issue |
Related article by @Lith (thank you ❤️ ) https://medium.com/@vanessa.pasque/implement-apple-sign-in-with-strapi-a9f0ff4b6417 |
@derrickmehaffy |
Currently no as it requires us to purchase a dev license to properly test. A user in our discord was able to add apple login to users-permissions the other day. |
@derrickmehaffy I'd love to see AppleID sign-in method in strapi. Do not hesitate to reach me via email. I'll be happy to help (e.g. can create an app for testing purposes) |
As mentioned before, this isn't something we will likely implement as it requires us to purchase and maintain a license from Apple to do so, this is why we don't implement several other providers. Eventually we want to move the auth providers to their own packages much like we do with upload and email so that a community member can maintain an Apple one. |
I've created a PR for this one. Please have a look at it :) |
This RFC refer to strapi/strapi#6586
RFC Preview link
Update
I've begin a draft article about how to implement Apple Sign In right now on Strapi
All feedback are welcome, I will update RFC informations and the PR about Apple SignIn soon.