fix: make CheckBox styling respect the figma design #1806
Conversation
🦋 Changeset detectedLatest commit: 9d1e69a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @rami-pro nice catch 🚀 we'll take a look as soon as possible 🙏 |
|
@hanpaine is there anything to change to merge this PR ? |
|
Hey @rami-pro it hasn't been reviewed by the dev team yet; they'll let you know when they can get to it 🙏 |
There was a problem hiding this comment.
@rami-pro You will need to add a changeset to your PR. See contributing docs for more information. Let me know if anything is not clear.
The cursor is still setting the cursor to 'pointer' on hover when the checkbox is disabled. @lucasboilly is that what we want?
markkaylor
added
pr: fix
|
Hey @markkaylor :) No, we should change the cursor to its disabled version. It's supposed to look like this:
|
|
Do we have the disabled version of the cursor on strapi/icons, didn't find one ? @lucasboilly @markkaylor |
|
@rami-pro it isn't in the icons, I think it's supposed to be fixed by typing something like |
Yes that's right you should be able to apply the cursor styles with css |
rami-pro
force-pushed
the
fix/checkbox-styling
branch
from
fedceeb to
9d1e69a
Compare
|
I answwered your requests, thanks @lucasboilly @markkaylor for review |
What does it do?
I just added styling to my checkbox styeled component, and changed icon's color based on the state of the checkbox if it's disabled or not
Why is it needed?
refer issue : strapi/strapi#22032
How to test it?
Check on the storybook and compare to figma design at link
Related issue(s)/PR(s)
strapi/strapi#22032