Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] Disabled checkboxes in Super Admin settings have a blue border and the check hasn’t the right color #22032

Open
yanniskadiri opened this issue Oct 30, 2024 · 2 comments · May be fixed by strapi/design-system#1806
Open

[Design] Disabled checkboxes in Super Admin settings have a blue border and the check hasn’t the right color #22032

yanniskadiri opened this issue Oct 30, 2024 · 2 comments · May be fixed by strapi/design-system#1806
Assignees
@lucasboilly
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: rbac status: confirmed Confirmed by a Strapi Team member or multiple community members version: 5

Comments

@yanniskadiri
Copy link

Current design

Image

Expected design

Image

Figma file: https://www.figma.com/design/NmL2GP7zw2bS4G5CW1xVqm/%5BEXPERIMENTAL%5D-Strapi-CMS---UI-Kit?node-id=16985-51790&node-type=frame&t=7oMHD4xIfBLoVvKe-0
@yanniskadiri yanniskadiri converted this from a draft issue Oct 30, 2024
@yanniskadiri yanniskadiri changed the title Disabled checkboxes in Super Admin settings have a blue border and the check hasn’t the right color [Design] Disabled checkboxes in Super Admin settings have a blue border and the check hasn’t the right color Oct 30, 2024
@yanniskadiri yanniskadiri added severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve status: confirmed Confirmed by a Strapi Team member or multiple community members source: rbac issue: bug Issue reporting a bug version: 5 labels Oct 30, 2024
@mukulpadwal
Copy link

mukulpadwal commented Nov 2, 2024 •
edited
Loading

@yanniskadiri, It appears that the checkbox is integrated within the @strapi/design-system. To implement the required changes, we may need to adjust the CSS specifically for the checkbox in that repository. While I could be mistaken, this is the conclusion I've drawn from my review of the codebase.

@rami-pro rami-pro linked a pull request Nov 4, 2024 that will close this issue
Open
@rami-pro
Copy link

rami-pro commented Nov 4, 2024

@yanniskadiri @mukulpadwal it's indeed a styling issue in @strapi/design-system, I took the initiative to fix it at the following PR

@lucasboilly lucasboilly self-assigned this Nov 7, 2024
@lucasboilly lucasboilly added the good first issue Good for newcomers label Nov 7, 2024
@lucasboilly lucasboilly linked a pull request Dec 13, 2024 that will close this issue
fix: make CheckBox styling respect the figma design strapi/design-system#1806
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasboilly lucasboilly

Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: rbac status: confirmed Confirmed by a Strapi Team member or multiple community members version: 5
Projects
Strapi 5 - Bug Tracker
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make CheckBox styling respect the figma design rami-pro/design-system
4 participants
@lucasboilly @yanniskadiri @rami-pro @mukulpadwal