Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINI_EPIC: wormchain should upgrade to new Cosmos SDK v0.47.x fork #51

Open
16 of 18 tasks
Tracked by #4
joelsmith-2019 opened this issue Jul 11, 2024 · 8 comments
Open
16 of 18 tasks
Tracked by #4
Assignees

Comments

@joelsmith-2019
Copy link

joelsmith-2019 commented Jul 11, 2024

Relies on the new fork: #30

Game plan:

  • prep all the changes
  • don't make them until we're ready (consensus-breaking)

Tasks

  1. 1 of 2
    joelsmith-2019 pharr117
  2. joelsmith-2019
  3. joelsmith-2019
  4. 🤮 Consensus-breaking
    pharr117
  5. 9 of 10
    joelsmith-2019
  6. joelsmith-2019
@joelsmith-2019
Copy link
Author

Started work on this while I wait for Nikhil's response on how to test the new Cosmos SDK v0.47.x fork.

@jonathanpberger jonathanpberger changed the title wormchain should upgrade to new Cosmos SDK v0.47.x fork wormchain should upgrade to new Cosmos SDK v0.47.x fork Jul 12, 2024
@joelsmith-2019
Copy link
Author

This issue will need to be finished before we can fully test the Cosmos SDK v0.47.12 fork.

@jonathanpberger jonathanpberger changed the title wormchain should upgrade to new Cosmos SDK v0.47.x fork MINI_EPIC: wormchain should upgrade to new Cosmos SDK v0.47.x fork Jul 15, 2024
@joelsmith-2019
Copy link
Author

The current branch is now passing go mod tidy. Now time to migrate away from deprecated code and implement all the latest API changes.

@joelsmith-2019
Copy link
Author

Draft PR for work: wormhole-foundation#4034

Repo is almost compiling & running unit tests. Just ironing out a few areas.

@jonathanpberger
Copy link

API changes have been made to 47, nearly compiliing. Looking into wasmd fork and gonna look at ante handlers to see if we can get off fork. Next: ICT tests. Almost done!

@jtieri
Copy link
Member

jtieri commented Jul 29, 2024

@joelsmith-2019 is shipping!! gonna find some time to keep pushing on this as a group

@jtieri
Copy link
Member

jtieri commented Aug 2, 2024

Protos need built with ignite-cli but we have to rebuild it with Go 1.21

@joelsmith-2019
Copy link
Author

I made the mistake of getting TokenFactory to parse with v0.47, but I never upgraded it to v0.47. Currently working on this upgrade which should get a majority of the finished ICTs passing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants