Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmWasm should be upgraded to v1.5 #12

Open
2 tasks done
Tracked by #4 ...
jonathanpberger opened this issue Jun 17, 2024 · 4 comments
Open
2 tasks done
Tracked by #4 ...

CosmWasm should be upgraded to v1.5 #12

jonathanpberger opened this issue Jun 17, 2024 · 4 comments

Comments

@jonathanpberger
Copy link

jonathanpberger commented Jun 17, 2024

  • Upgrade deps
  • check: are there changes to the APIs which require CW updates?
@pharr117
Copy link

pharr117 commented Jun 18, 2024

As a quick sanity check, I ran a naive update from v1.1.1 to v1.5.2 of wasmvm on their repo:

go get github.com/CosmWasm/[email protected]
make build/wormchaind

As expected, the update breaks the codebase due to incompatibilities between the fork of wasmd and [email protected].

This one will need to wait for #13 to be finished, as long as #13 is resolved in such a way as to make it compatible with wasmvm v1.5.2.

@pharr117
Copy link

Marked as Waiting due to dependency on #13

@jonathanpberger jonathanpberger changed the title CosmWasm should be upgraded to v1.5 ~or v2.0 (we'll provide a recommendation).~ CosmWasm should be upgraded to v1.5 Jun 21, 2024
@jonathanpberger
Copy link
Author

Decided: we'll do 1.5 (not v2.0)

Reece recommended that the risk/reward isn't worth it: too new, bugs on tokenfactory for chains which deployed it. Let's hold off for now.

@pharr117
Copy link

Marked as Consensus Breaking since the required update to wasmd is Consensus Breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants