-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix linter warnings #1270
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
"github.com/stretchr/testify/require" | ||
"go.uber.org/zap/zaptest" | ||
|
||
"cosmossdk.io/math" | ||
|
||
"github.com/cosmos/cosmos-sdk/types" | ||
|
||
"github.com/strangelove-ventures/interchaintest/v8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: add optional git hooks for vscode peeps
@@ -112,7 +108,7 @@ func TestDB_Concurrency(t *testing.T) { | |||
for { | |||
if ctx.Err() != nil { | |||
// Context was canceled; querying is finished. | |||
return nil | |||
return nil //nolint: nilerr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove since ignoring this linter type now
@@ -191,7 +192,7 @@ func (tn *ChainNode) NewSidecarProcess( | |||
VolumeName: v.Name, | |||
ImageRef: image.Ref(), | |||
TestName: tn.TestName, | |||
UidGid: image.UidGid, | |||
UIDGID: image.UIDGID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user breaking - lets until v10 - create ticket for this. Don't want people to have to refactor their test
This PR updates the CI jobs for linting and running tests to use current deps. It also fixes all the linter warnings from
golangci-lint
.