chore(provenance): add required chain build parameter #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi .. the most recent 1.19.0 version of their repo doesn't have this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Building on
muslandalpine 3.19produces an error of this form.Solution
Added a comment like is present for Axelar.
Seeing this problem means there's some compatibility issues that aren't great. Since this isn't defined in the yaml, the automated process that builds and pushes these images will no longer work. It also can't be added to the config either because older chain tags might need to be on alpine versions before the specified flag.
This isn't a problem for Provenance because we plan on building and pushing our own images.