feature branch: lint Twig files with twigstan/twigstan #95

COil · 2024-10-18T16:21:57Z

This branch adds twigstan/twigstan to lint Twig files with types check.

Q	A
Branch?	twigstan
Cleanup?	no
Bug fix?	may be
Fixed tickets	NA
New feature?	yes
Doc added?	todo
Tests pass?	yes
Deprecations?	no
License	MIT

COil · 2024-10-18T16:23:52Z

Before :

18/10/2024 : 17 errors found :

vendor/bin/twigstan                                                                                                                                                   ✔   8.3.11  18:19:58
TwigStan by Ruud Kamphuis and contributors.
Finding dependencies for 8 templates...
Found 0 dependencies...
Compiling 8 templates...
Flattening 8 templates...
Collecting scopes...
 8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Injecting scope into templates...
Analyzing templates
 8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Variable 'composer' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_ComposerAction.php:126
🌱 templates/App/Controller/ComposerAction.html.twig:16

Variable 'form' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_FormAction.php:148
🌱 templates/App/Controller/FormAction.html.twig:21

Variable 'dto' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_FormAction.php:152
🌱 templates/App/Controller/FormAction.html.twig:28

Variable 'dto' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_FormAction.php:156
🌱 templates/App/Controller/FormAction.html.twig:33

Variable 'dto' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_FormAction.php:160
🌱 templates/App/Controller/FormAction.html.twig:38

Variable 'dto' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_FormAction.php:164
🌱 templates/App/Controller/FormAction.html.twig:43

Variable 'dto' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_FormAction.php:168
🌱 templates/App/Controller/FormAction.html.twig:48

Variable 'dto' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_FormAction.php:172
🌱 templates/App/Controller/FormAction.html.twig:53

Variable 'form' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_FormAction.php:183
🌱 templates/App/Controller/FormAction.html.twig:67

Variable 'readme' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_HomeAction.php:126
🌱 templates/App/Controller/HomeAction.html.twig:9

Variable 'form' does not exist.
🔖 offsetAccess.notFound
🐘 compiled__form.php:19
🌱 templates/_form.html.twig:2

Variable 'status_code' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_error.php:138
🌱 templates/bundles/TwigBundle/Exception/error.html.twig:5

Variable 'status_code' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_error.php:152
🌱 templates/bundles/TwigBundle/Exception/error.html.twig:10

Variable 'status_text' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_error.php:156
🌱 templates/bundles/TwigBundle/Exception/error.html.twig:12

Variable 'status_code' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_error.php:160
🌱 templates/bundles/TwigBundle/Exception/error.html.twig:12

Variable 'status_code' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_error.php:164
🌱 templates/bundles/TwigBundle/Exception/error.html.twig:14

Variable 'status_code' does not exist.
🔖 offsetAccess.notFound
🐘 compiled_error.php:168
🌱 templates/bundles/TwigBundle/Exception/error.html.twig:15

Found 17 errors

COil · 2024-10-18T18:43:42Z

After :

TwigStan by Ruud Kamphuis and contributors.
Finding dependencies for 8 templates...
Found 0 dependencies...
Compiling 8 templates...
Flattening 8 templates...
Collecting scopes...
 8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Injecting scope into templates...
Analyzing templates
 8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

No errors found

castor.php

.gitignore

twig-loader.php

twigstan.php

templates/App/Controller/FormAction.html.twig

src/Kernel.php

ruudk · 2024-10-21T10:00:53Z

After looking at this, I spotted a few bugs/problems in TwigStan that I solved.

I created a PR with updates:

TwigStan tweaks #99

COil · 2024-10-28T20:44:37Z

templates/App/Controller/FormAction.html.twig

@@ -45,7 +45,7 @@

                <tr>
                    <th>Birthay</th>
-                    <td>{{ dto.birthday|date('Y-m-d') }}</td>
+                    <td>{{ dto.birthday ? dto.birthday|date('Y-m-d') : 'NA' }}</td>


Bug found ! 🐛

COil · 2024-11-17T17:23:41Z

Hello @ruudk, I have rebased the branch and updated TwigStan and I have many new errors, it is expected?

https://github.com/strangebuzz/MicroSymfony/actions/runs/11880748477/job/33104272440?pr=95

ruudk · 2024-11-17T17:31:36Z

Did you also update twig/twig?

ruudk · 2024-11-17T17:32:19Z

And phpstan/phpstan

COil · 2024-11-17T17:51:57Z

And phpstan/phpstan

Yes, it is Phpstan 2 (2.0.2) now!

I have reverted Phpstan to 1.0.2 for now. You can drop me a message here, but you think the PHPStab 2.0 can be done.

COil · 2024-11-17T17:52:57Z

Did you also update twig/twig?

Twig v3.15.0

ruudk · 2024-11-18T08:13:24Z

I found the problem. Twig 3.15 was released in the weekend without me knowing it.

I made sure this won't happen again by doing:

From now on, TwigStan will support specific / fixed versions of Twig.

Please update twigstan/twigstan.

Btw, PHPStan 2 is not yet supported, it will be soon:

so it would be best if you could use 1.12 for now.

COil added DX Developer Experience feature branch Feeature branch demo wip labels Oct 18, 2024

COil self-assigned this Oct 18, 2024

COil force-pushed the twigstan branch 2 times, most recently from 77b7a47 to b9ea9dd Compare October 18, 2024 18:41

COil force-pushed the twigstan branch 2 times, most recently from 8fc4d16 to 7e7edc1 Compare October 18, 2024 18:46

COil changed the title ~~feature branch: lint twig files with twigstan~~ feature branch: lint Twig files with twigstan/twigstan Oct 18, 2024

COil force-pushed the twigstan branch 2 times, most recently from 1c1c766 to 3e27c17 Compare October 18, 2024 19:18

COil mentioned this pull request Oct 18, 2024

Dependency problem with nikic/php-parser twigstan/twigstan#62

Closed

ruudk reviewed Oct 20, 2024

View reviewed changes

castor.php Outdated Show resolved Hide resolved