Release: Prerelease 8.5.0-beta.8 #30156
Open
+462
−571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Add `configDir` option to example configs
- Move coverage exclusion config under Set up heading
- Add `**/.storybook/**`
Docs: A11y minor fixes
Docs: Fixes found during 8.5 QA
…hadow-on-scrollbar UI: Fix overlapping shadow of testing module on scrollbar
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
16 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| framework: '@storybook/your-framework', | ||
| stories: ['../src/**/*.mdx', '../stories/**/*.stories.@(js|jsx|mjs|ts|tsx)'], | ||
| async webpackFinal(config) { | ||
| storybookBaseConfig.module?.rules?.push({ |
There was a problem hiding this comment.
logic: storybookBaseConfig is undefined - should be using config parameter instead
| framework: '@storybook/your-framework', | ||
| stories: ['../src/**/*.mdx', '../stories/**/*.stories.@(js|jsx|mjs|ts|tsx)'], | ||
| async webpackFinal(config) { | ||
| storybookBaseConfig.module?.rules?.push({ |
There was a problem hiding this comment.
logic: storybookBaseConfig is undefined - should be using config parameter instead
| async viteFinal(config) { | ||
| return { | ||
| ...config, | ||
| plugins: [...(config.plugins ?? []), graphql()], |
There was a problem hiding this comment.
logic: graphql() function is used but not imported or defined
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-beta.7
branch
from
bb315b3 to
83a5489
Compare
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-beta.7
branch
from
83a5489 to
587aeeb
Compare
…only Maintenance: Move `@types/node` to `devDeps` consistently
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-beta.7
branch
from
587aeeb to
ec4108a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.0-beta.7to8.5.0-beta.8.Once this pull request is merged, it will trigger a new release of version
8.5.0-beta.8.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:@types/nodetodevDepsconsistently #30163acb6a30a1f91d5ac6ef1c9a5412864b2b768583cIf you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-beta.8
@types/nodetodevDepsconsistently - #30163, thanks @ndelangen!