feat: update docs for client v15 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
approved these changes
Jun 14, 2024
src/pages/docs/concepts/car.md
Outdated
Comment on lines
105
to
108
| const inStream = fs.createReadStream(filename) | ||
| const car = await CarReader.fromIterable(inStream) | ||
| const client = makeStorageClient() | ||
| const cid = await client.uploadCAR(car) |
There was a problem hiding this comment.
note that this is not correct, but we can update in follow up PR given it is not the scope goal of the PR #94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v15 reduces the amount of code and additional dependencies required to be installed to make for better DX.