Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): added parser arg #2737

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

rudfoss-rr
Copy link

@rudfoss-rr rudfoss-rr commented Nov 15, 2024

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

If indicated yes above, please describe the breaking change(s).

Remove this quote before creating the PR.

Additional context

Suggestion for adding support for a parser argument to the CLI so that the appropriate parser can be selected for Json files.

@rudfoss-rr rudfoss-rr requested a review from a team as a code owner November 15, 2024 10:14
@rudfoss-rr
Copy link
Author

@mnaumanali94 I was having trouble fixing the commit message issues so I reopened a new PR instead. Sorry for the confusion. I've addressed the lint issues, but I'm having trouble getting all tests to work as well as adding appropriate tests of my own. Would love some help if you have time as I haven't worked with test-harness before and can't seem to get them to run locally in dev-container.

@rudfoss-rr rudfoss-rr mentioned this pull request Nov 15, 2024
4 tasks
@mnaumanali94
Copy link
Contributor

@rudfoss-rr So to run harness tests you first need to build the binaries. For that cd into the package/cli folder and run yarn build.binary and then at the root level run yarn test.harness. Let us know if you run into issues!

@rudfoss-rr
Copy link
Author

@rudfoss-rr So to run harness tests you first need to build the binaries. For that cd into the package/cli folder and run yarn build.binary and then at the root level run yarn test.harness. Let us know if you run into issues!

Thanks! I've updated tests and attempted to add a few scenarios of my own, but was unable to completely rebuild the scenario tests using either test.harness, build or build.binary so I wasn't able to properly verify all scenarios locally. I'm guessing there is just some script I'm missing.

I now see that I've broken a few other tests, but I'm not sure exactly why. If you could have a look and point me in the right direction that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants