Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix error "this.formats.has is not a function" #2651

Closed

Conversation

riccardo-angelilli
Copy link

@riccardo-angelilli riccardo-angelilli commented Jul 5, 2024

Fixes #2362

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@riccardo-angelilli riccardo-angelilli requested a review from a team as a code owner July 5, 2024 06:03
@riccardo-angelilli riccardo-angelilli changed the title fix error "this.formats.has is not a function" fix(rule): fix error "this.formats.has is not a function" Jul 5, 2024
@riccardo-angelilli riccardo-angelilli changed the title fix(rule): fix error "this.formats.has is not a function" fix(core): fix error "this.formats.has is not a function" Jul 5, 2024
@riccardo-angelilli
Copy link
Author

fixed PR title

@brendarearden
Copy link
Contributor

Please resolve linting errors to get it ready for review.

@riccardo-angelilli
Copy link
Author

I have modified the commit message but the lint is still red

@riccardo-angelilli
Copy link
Author

try closing an reopening the PR

@riccardo-angelilli
Copy link
Author

I will open a brand new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when handling formats if json rulesets are extended
2 participants