-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(functions): expand xor function and add exclusive option for or functionality #2616
Open
cuttingclyde
wants to merge
8
commits into
stoplightio:develop
Choose a base branch
from
cuttingclyde:feature/expand-xor-add-or
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(functions): expand xor function and add exclusive option for or functionality #2616
cuttingclyde
wants to merge
8
commits into
stoplightio:develop
from
cuttingclyde:feature/expand-xor-add-or
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuttingclyde
changed the title
Expand xor function and add or function
feat(functions): Expand xor function and add or function
May 2, 2024
4 tasks
…re/expand-xor-add-or
cuttingclyde
changed the title
feat(functions): Expand xor function and add or function
feat(functions): expand xor function and add or function
May 3, 2024
This has now been merged with stoplightio:develop containing prior "xor" PR #2614, "feat(rulesets): add multiple xor", and rest of spectral develop branch. |
cuttingclyde
changed the title
feat(functions): expand xor function and add or function
feat(functions): expand xor function and add exclusive option for or functionality
May 4, 2024
Define exclusive as optional. Co-authored-by: Brenda Rearden <[email protected]>
Safely handle any type of exclusive argument, not just boolean or null values. Co-authored-by: Brenda Rearden <[email protected]>
mnaumanali94
requested review from
frankkilcommins
and removed request for
chohmann
November 15, 2024 14:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396 . This has now been merged with stoplightio:develop containing prior "xor" PR #2614.
Checklist
Does this PR introduce a breaking change?
(Just saw JeanArhancet's similar pull request, feat(rulesets): add multiple xor .)
FDX (see below) has extended XOR here to support from 1 to any number of properties. This would match the XOR logical function, that as long as exactly one of the (1 or more) properties is defined, then the rule passes. With just one property defined in the functionOptions,
xor
becomes redundant withdefined
function.Updated error response messages to account for possibility of schema matching any number of properties or schema not matching any of any number of functionOption properties.
Updated functionOptions error messages to show example arrays containing from one to three ("and etc") properties.
Since
then
can take an array which implements AND-ing of rule requirements, this PR also defines and adds anexclusive
(default true) option to XOR function to provide OR behavior.exclusive: false
works just likexor
for requiring at least one matching property, but then permits more than one matching property as valid and satisfying the rule.Updated functions documentation for
xor
changes to allow more than two properties and newexclusive
option to permit multiple matches.Additional context
The Financial Data Exchange (FDX, https://financialdataexchange.org) industry consortium for Open Banking delivers 13 OpenAPI 3.1 files with nearly 17,000 lines, 47 paths, 70 operations and 374 defined schemas, We enforce our FDX API Style Guide using 48 custom spectral rules and 23 overrides over 870 ruleset lines. We wanted to enforce that
type
was defined for each schema, but a schema can get its type in 3 (or 4) ways:type
,$ref
, oroneOf
. (We are not usingallOf
to definetype
.) This was ideal for an unresolved xor rule with propertiestype
,$ref
, oroneOf
. We initially implemented this as a custom function which met our needs, so are now contributing this to the spectral community. Our rule using our customxor
function:Secondly, there is an OR-rule opportunity to ensure that defined schemas contain sufficient documentation, as a style guide requirement. In particular, each schema ought to have its use / purpose described for users, which can be done in any of
title
,summary
, ordescription
fields. This is an ideal place for anor
function, since any one of those can provide the required schema documentation text, but two or three of them is also just as valid (or better!). A similar example (also included in this PR's tests), would be requiring a helpful example for atype: string
schema, which could be provided by any offormat
,example
, orpattern
fields in the API spec, but again more than one is acceptable.