Refactor: use monadic operators and prefer NonZeroU64
for seconds
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! Fun little project here. Figured that a little bit of cleanup would be appreciated. In this PR:
match
statements into their monadic counterparts so that the control flow is more "flat" and "linear", so to speak.seconds
option to take in anOption<NonZeroU64>
instead of anOption<u64>
. This allows the compiler to optimize for memory layout. The former ensures thatseconds
is represented in memory as if it were a plainu64
(which is not the case for the latter). Moreover, it doesn't make sense to provide zero delay, anyway. 😅That is all. Thanks! 🎉