Skip to content

Commit

Permalink
[sw/lib] SDI: remove redundant HAL functions
Browse files Browse the repository at this point in the history
The "normal" SDI put/get functions are already non-blocking
  • Loading branch information
stnolting committed Jul 19, 2024
1 parent 2c10925 commit e27ad73
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 35 deletions.
18 changes: 8 additions & 10 deletions sw/lib/include/neorv32_sdi.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,14 @@ enum NEORV32_SDI_CTRL_enum {
* @name Prototypes
**************************************************************************/
/**@{*/
int neorv32_sdi_available(void);
void neorv32_sdi_setup(uint32_t irq_mask);
void neorv32_sdi_rx_clear(void);
void neorv32_sdi_disable(void);
void neorv32_sdi_enable(void);
int neorv32_sdi_get_fifo_depth(void);
int neorv32_sdi_put(uint8_t data);
void neorv32_sdi_put_nonblocking(uint8_t data);
int neorv32_sdi_get(uint8_t* data);
uint8_t neorv32_sdi_get_nonblocking(void);
int neorv32_sdi_available(void);
void neorv32_sdi_setup(uint32_t irq_mask);
void neorv32_sdi_rx_clear(void);
void neorv32_sdi_disable(void);
void neorv32_sdi_enable(void);
int neorv32_sdi_get_fifo_depth(void);
int neorv32_sdi_put(uint8_t data);
int neorv32_sdi_get(uint8_t* data);
/**@}*/


Expand Down
28 changes: 3 additions & 25 deletions sw/lib/source/neorv32_sdi.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ void neorv32_sdi_enable(void) {
/**********************************************************************//**
* Get SDI FIFO depth.
*
* @return FIFO depth (number of entries), zero if no FIFO implemented
* @return FIFO depth (number of entries), 1 if no FIFO implemented
**************************************************************************/
int neorv32_sdi_get_fifo_depth(void) {

Expand All @@ -96,7 +96,7 @@ int neorv32_sdi_get_fifo_depth(void) {
* Push data to SDI output FIFO.
*
* @param[in] data Byte to push into TX FIFO.
* @return -1 if TX FIFO is full.
* @return -1 if TX FIFO is full, 0 if success.
**************************************************************************/
int neorv32_sdi_put(uint8_t data) {

Expand All @@ -110,22 +110,11 @@ int neorv32_sdi_put(uint8_t data) {
}


/**********************************************************************//**
* Push data to SDI output FIFO (ignoring TX FIFO status).
*
* @param[in] data Byte to push into TX FIFO.
**************************************************************************/
void neorv32_sdi_put_nonblocking(uint8_t data) {

NEORV32_SDI->DATA = (uint32_t)data;
}


/**********************************************************************//**
* Get data from SDI input FIFO.
*
* @param[in,out] Pointer fro data byte read from RX FIFO.
* @return -1 if RX FIFO is empty.
* @return -1 if RX FIFO is empty, 0 if success.
**************************************************************************/
int neorv32_sdi_get(uint8_t* data) {

Expand All @@ -137,14 +126,3 @@ int neorv32_sdi_get(uint8_t* data) {
return -1;
}
}


/**********************************************************************//**
* Get data from SDI input FIFO (ignoring RX FIFO status).
*
* @param[in] data Byte read from RX FIFO.
**************************************************************************/
uint8_t neorv32_sdi_get_nonblocking(void) {

return (uint8_t)NEORV32_SDI->DATA;
}

0 comments on commit e27ad73

Please sign in to comment.