-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for stm32c011j4m6 #2359
Conversation
alexnagelberg
commented
May 5, 2024
•
edited by fpistm
Loading
edited by fpistm
- Adds C011J(4-6)Mxx variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexnagelberg
Thanks for this PR.
Could you update tour PR to reference the new generic in the README.md and add a generic clock using LL API (you can use STM32CubeMx to generate it).
Plus a small update of the ldscript to be generic.
Here an example: https://github.com/stm32duino/Arduino_Core_STM32/pull/2048/files
@fpistm Sure, although this ldscript was generated by cubemx, so I'm not sure how to get it to include but will play around. Just a heads up that this PR is not ready so I put it in draft, mostly as a reminder to myself to finish it. |
Added remaining changes. Still in testing with my new chip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor update to avoid astyle issue.
One thing I'm concerned about with the existing code is default generic Serial is I believe pointed at the same pins which will only work for half-duplex. May want to use the same pin configuration as the bootloader uses for USART1. I've been having trouble getting it to work even with pin changes though. |
Pins defined in the variant generic have no link with the built-in bootloader. Generic files could not be changed as they are automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alexnagelberg If it is ok for you I will merge the PR. |
@fpistm Serial doesn't appear to be setup correctly but everything else appears working. I'm okay with it being merged and staying yellow heart. |
The only thing which could avoid serial to work is a wrong clock config anyway on C0 clock tree is not complicated so it should basically work. |
Looking at the package, by default Serial is mapped on USART1 Using PA0 and PA1 but they are both on the same pin. So to test you can try to redefine the RX on PC14 before calling
|
I've squash you PR and update the clock config to use LL instead of HAL. This allows to save 1K flash. |
Codespell issue can be safely ignored (see #2379). |