Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for your work on elm-analyse :)
This PR aims to solve #236, which afaik is an intended behaviour which solves #22, an old issue you opened up yourself. This is a proposal to rollback that behaviour, for two reasons:
NoUnusedDependencies
check cannot be configured nor disabled in any way at this momentnode_modules
can be easily configured fromelm-analyse.json
, and I think nowadays is more common to have a couple folder with elm sources and that can be manually added toelm-analyse.json
rather than using.
as the scope for all elm filesFinally, I've also added a
Dockerfile
so that the project can be built easily, in spite of all the versions of node/npm/typescript one may have on their own system.EDIT: the windows build fails because it fails to install
elm-platform
. Any clue?