-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Move to query package #290
Draft
gmatthews20
wants to merge
7
commits into
main
Choose a base branch
from
move-to-query-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace openstack query to use new package
Remove openstack_query files from lib and respective unit tests, these are now in a dedicated repository, stfc/openstack-query-library
gmatthews20
force-pushed
the
move-to-query-package
branch
from
December 12, 2024 11:37
2f983a0
to
1062dc8
Compare
Fix broken import in test Change naming to be consistant Update links in docs
gmatthews20
force-pushed
the
move-to-query-package
branch
from
December 12, 2024 11:38
1062dc8
to
aeebed9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 98.24% 97.68% -0.57%
==========================================
Files 239 135 -104
Lines 9028 4875 -4153
Branches 529 266 -263
==========================================
- Hits 8870 4762 -4108
+ Misses 137 102 -35
+ Partials 21 11 -10 ☔ View full report in Codecov by Sentry. |
Bump query library version to v0.1.3
Bump query library version to v0.1.4
gmatthews20
force-pushed
the
move-to-query-package
branch
from
December 13, 2024 10:42
e4a734d
to
798a31a
Compare
Update HypervisorSate enum so it's easier to understand and use Refactor check valid sate into separate function Return HypervisorState instead of string from get_hypervisor_state Update tests Update to work with new version of query library
gmatthews20
force-pushed
the
move-to-query-package
branch
from
December 13, 2024 10:44
798a31a
to
5363a77
Compare
Add new server query to find number of servers on a hypervisor
gmatthews20
force-pushed
the
move-to-query-package
branch
from
December 13, 2024 12:16
fbd67cf
to
1243bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Query Library has been moved to its own dedicated repository: https://github.com/stfc/openstack-query-library
This PR removes the query library directories and changes the stackstorm workflows to use the new package from the query library repository
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
lib
directory?lib
layers?