-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lags to vafs #318
Add lags to vafs #318
Conversation
4a0a989
to
484c2d3
Compare
Are these lags consistent with the on-the-fly correlations (@harveydevereux)? |
Yes these will be, given the right on-the-fly options. But it is possible to have correlations returned with lags that don't have a uniform step due to the window averaging, sample frequency options etc. lags = np.arange(n_steps) * time_step Currently don't have fft as an option though, perhaps we should |
da7363d
to
18010a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think test_post_process.py::test_vaf
needs updating to get the vaf from the returned tuple, and ideally probably should check the lag while it's at it too.
Co-authored-by: ElliottKasoar <[email protected]>
64e2ec1
to
ce710bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the notes on filter_atoms
!
Fixes #253