Update pre-commit to use ruff #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinelena
previously approved these changes
Nov 20, 2024
ElliottKasoar
force-pushed
the
update-pre-commit
branch
from
0f90ea3 to
9c28f46
Compare
|
(Rebased to resolve conflicts with #163) |
alinelena
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #157
Note: There are newer versions of
ruff(0.7.4), but these would not allow us to use the latestjanus-core, so that needs updating first.I've also added an ignore for
N806(checks for the use of non-lowercase variable names in functions), as this is throwing errors about the returns fromCalculationFactoryin some, but not all, cases. This should probably be revisited at some point.Partially resolves #156