-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Closes #1280) fix ref guide warnings #2776
base: master
Are you sure you want to change the base?
Conversation
…ple to dataclass
The CI failed at the package installation stage:
I don't think this is the fault of this PR. Possibly something has changed in the GHA environment? |
In fact, the CI doesn't test the Jupyter notebooks anymore as they are out of date. We could probably therefore relax our dependencies? EDIT: in fact we don't have jupyter as a dependence and I don't know what requires importlib-metadata to be pinned? I think this is related to the fact that Python 3.8 has reached EoL. I'll create a new issue - #2777. |
Another update. The CI installs jupyter itself (i.e. it's not in setup.py) and then does run the notebooks in examples/gocean/eg1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2776 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 356 356
Lines 49446 49480 +34
=======================================
+ Hits 49388 49422 +34
Misses 58 58 ☔ View full report in Codecov by Sentry. |
No description provided.