Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #1280) fix ref guide warnings #2776

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Conversation

arporter
Copy link
Member

No description provided.

@arporter arporter self-assigned this Nov 13, 2024
@arporter arporter marked this pull request as draft November 13, 2024 15:02
@arporter
Copy link
Member Author

The CI failed at the package installation stage:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
jupyterlab-server 2.24.0 requires importlib-metadata>=4.8.3; python_version < "3.10", but you have importlib-metadata 4.2.0 which is incompatible.

I don't think this is the fault of this PR. Possibly something has changed in the GHA environment?

@arporter
Copy link
Member Author

arporter commented Nov 13, 2024

In fact, the CI doesn't test the Jupyter notebooks anymore as they are out of date. We could probably therefore relax our dependencies?

EDIT: in fact we don't have jupyter as a dependence and I don't know what requires importlib-metadata to be pinned?

I think this is related to the fact that Python 3.8 has reached EoL. I'll create a new issue - #2777.

@arporter
Copy link
Member Author

Another update. The CI installs jupyter itself (i.e. it's not in setup.py) and then does run the notebooks in examples/gocean/eg1

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (9f4890a) to head (551a9fb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2776   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         356      356           
  Lines       49446    49480   +34     
=======================================
+ Hits        49388    49422   +34     
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant