Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(related to #2244) LFRic tiled colouring #2750

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

sergisiso
Copy link
Collaborator

Currently this PR is just to monitor the changes, tests and coverage or the LFRic tiled colouring implementations. It is unclear if we should merge this now or wait until the colouring code is refactored so that it can be encapsulated inside its associated transformation instead of spread it around the code.

@sergisiso sergisiso added the Blocked An issue/PR that is blocked by one or more issues/PRs. label Oct 22, 2024
@sergisiso sergisiso self-assigned this Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 81.11588% with 44 lines in your changes missing coverage. Please review.

Project coverage is 99.79%. Comparing base (816177c) to head (ce6c13a).

Files with missing lines Patch % Lines
src/psyclone/dynamo0p3.py 74.48% 25 Missing ⚠️
src/psyclone/domain/lfric/lfric_loop.py 79.24% 11 Missing ⚠️
src/psyclone/domain/lfric/lfric_kern.py 68.18% 7 Missing ⚠️
src/psyclone/transformations.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
- Coverage   99.88%   99.79%   -0.10%     
==========================================
  Files         356      356              
  Lines       49480    49674     +194     
==========================================
+ Hits        49422    49570     +148     
- Misses         58      104      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked An issue/PR that is blocked by one or more issues/PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant