(related to #2244) LFRic tiled colouring #2750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t fails at runtime)
… gungho, but threading is in the wrong loop)
sergisiso
added
the
Blocked
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2750 +/- ##
==========================================
- Coverage 99.87% 99.77% -0.10%
==========================================
Files 355 355
Lines 49324 49518 +194
==========================================
+ Hits 49260 49408 +148
- Misses 64 110 +46 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this PR is just to monitor the changes, tests and coverage or the LFRic tiled colouring implementations. It is unclear if we should merge this now or wait until the colouring code is refactored so that it can be encapsulated inside its associated transformation instead of spread it around the code.