ZAP

[NickLech]

ZAP files loaded

[mattebit]

The license of samlraider should not be edited or removed, you can append the ZAP one if needed, but i don't think it is needed for these files

[NickLech]

ZAP was giving an error due to the lack of a license. I will try to re-add the samlaider licence, which was automatically removed by a built-in feature of ZAP that I used to update the licenses.

[NickLech]

It does not allow me to build it if I have the other licence, I will search for a solution but for now could leave it like this, this branch was created so that I could send the link to the ZAP developers for an issue with the code

[mattebit]

Ok. The branch should already be visible, so I would wait to merge the PR until we assess this doubt

[mattebit]

Do the ZAP license need to be included in every file of the addon? please check if necessary. I would just put it in the code using ZAP libraries

[NickLech]

Yes, otherwise during the build if faild due to format violations

[mattebit]

the name should be ".gitignore"

[mattebit]

Ok. The branch should already be visible, so I would wait to merge the PR until we assess this doubt

[NickLech]

The issue is that we wanted to send the code for the ZAP plugin, so the branch needs to contain the code I submitted in the PR. Initially, I intended to send my repository, but it was later decided to create a dedicated branch for my code. If you think this is a problem, let me know, and I will ask the others how to proceed.

[NickLech]

Hy, I was able to change the rules for the build and now the MIT license should be present as well as some changes in the build file

[mattebit]

Hy, I was able to change the rules for the build and now the MIT license should be present as well as some changes in the build file

Please then verify with ZAP developers that this is ok for them.

The issue is that we wanted to send the code for the ZAP plugin, so the branch needs to contain the code I submitted in the PR. Initially, I intended to send my repository, but it was later decided to create a dedicated branch for my code. If you think this is a problem, let me know, and I will ask the others how to proceed.

I would just wait to merge and let them see your fork, but if @abisegna prefers to merge it is ok, but please do not merge into main until we assess these doubts

[NickLech]

Yes, I already asked them and they said: "The ZAP license header is only needed if you plan to contribute the
add-on and it will live in zap-extensions repo, otherwise you are free
to use whatever license you deem appropriate for your add-on. "

[mattebit]

Yes, I already asked them and they said: "The ZAP license header is only needed if you plan to contribute the add-on and it will live in zap-extensions repo, otherwise you are free to use whatever license you deem appropriate for your add-on. "

Ok. So you can remove the ZAP licence also from the mig-t files. The Saml Raider files must have their original license notice in their files