Skip to content

Commit

Permalink
Disable the Windows CI builds
Browse files Browse the repository at this point in the history
Setting up vcpkg tries to build xz from source, which fails because the
entire xz repo has now been made private or taken down. The vcpkg team
have been advised not to switch to an alternative repo [1], so for now
our Windows builds will always fail.

Turn those builds off, so that we don't get familiar with seeing red
status markers on all PR's CI results.

[1] microsoft/vcpkg#37957 - second comment is
the vcpkg team's "We have been explicitly asked by security folks to not
change the upstream [to a different repo] for liblzma at this time."
  • Loading branch information
stevecotton committed Apr 7, 2024
1 parent 8ade92b commit 673321d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ jobs:
strategy:
fail-fast: false
matrix:
cfg: [Debug, Release]
cfg: [] # All vcpkg builds require xz. Disabled while vcpkg and xz upstreams discuss recovery from the backdoor.
env:
CFG: ${{ matrix.cfg }}
VCPKG_FEATURE_FLAGS: dependencygraph
Expand Down

0 comments on commit 673321d

Please sign in to comment.