RSDK-7244: Expose data channel so TS SDK can listen for disconnect (v…

…iamrobotics#287)
stevebriskin · May 13, 2024 · 5929be5 · 5929be5
1 parent 612b3f8
commit 5929be5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/rpc/examples/echo/frontend/package-lock.json b/rpc/examples/echo/frontend/package-lock.json
diff --git a/rpc/js/package-lock.json b/rpc/js/package-lock.json
diff --git a/rpc/js/package.json b/rpc/js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@viamrobotics/rpc",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "license": "Apache-2.0",
   "dependencies": {
     "@improbable-eng/grpc-web": "^0.13.0",

diff --git a/rpc/js/src/dial.ts b/rpc/js/src/dial.ts
@@ -265,6 +265,7 @@ class authenticatedTransport implements grpc.Transport {
 export interface WebRTCConnection {
   transportFactory: grpc.TransportFactory;
   peerConnection: RTCPeerConnection;
+  dataChannel: RTCDataChannel;
 }
 
 async function getOptionalWebRTCConfig(
@@ -319,6 +320,8 @@ async function getOptionalWebRTCConfig(
 // PeerConnection itself. Care should be taken with the PeerConnection and is currently returned for experimental
 // use.
 // TODO(GOUT-7): figure out decent way to handle reconnect on connection termination
+// eslint-disable-next-line sonarjs/cognitive-complexity
+// eslint-disable-next-line func-style
 export async function dialWebRTC(
   signalingAddress: string,
   host: string,
@@ -637,7 +640,11 @@ export async function dialWebRTC(
     }
 
     successful = true;
-    return { transportFactory: cc.transportFactory(), peerConnection: pc };
+    return {
+      transportFactory: cc.transportFactory(),
+      peerConnection: pc,
+      dataChannel: dc,
+    };
   } finally {
     if (!successful) {
       pc.close();