Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Notification Service Extension to project #1

Open
wants to merge 1 commit into
base: step-1
Choose a base branch
from
Open

Add Notification Service Extension to project #1

wants to merge 1 commit into from

Conversation

steprescott
Copy link
Owner

@steprescott steprescott commented Dec 2, 2018 •
edited
Loading

No additional fils added other than what Xcode generates for you.

Please pay attention to the project file. From this example you can see it is difficult to code review changes made to a project file.

@steprescott steprescott mentioned this pull request Dec 2, 2018
Open
@steprescott steprescott added the xcodeproj Work is done using default Xcode methods label Dec 2, 2018
guacjack
guacjack approved these changes Dec 4, 2018
View reviewed changes
Copy link
Collaborator

@guacjack guacjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guacjack guacjack guacjack approved these changes

Assignees
No one assigned
Labels
xcodeproj Work is done using default Xcode methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steprescott @guacjack