Feature: add boolean rule #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@borkweb Mind giving this one a review when you have a chance? Need it for checkboxes in GiveWP 3.0. 👍 |
JasonTheAdams
force-pushed
the
feature/boolean-rule
branch
from
087d5cc
to
5acc012
Compare
|
I force pushed as I realized I had based it off the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
booleanrule that validates and sanitizes. It accepts any value that the FILTER_VALIDATE_BOOLEAN filter allows. This does include some trimming (" yes ") and casing ("YeS"), which I'm a bit on the fence about, but I'm leaning is fine. We can add astrictBooleanin the future if we want something tighter.Finally, it uses that filter to sanitize the value into a resulting true/false.