Remove use of deprecated commands #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
approved these changes
May 1, 2024
There was a problem hiding this comment.
lgtm. tried it locally and passed:
$ make \
CORE_GIT_REF=https://github.com/stellar/stellar-core.git#v21.0.0rc1 \
CORE_COMPILE_CONFIGURE_FLAGS="--disable-tests" \
SOROBAN_RPC_GIT_REF=https://github.com/stellar/soroban-rpc.git#main \
SOROBAN_CLI_GIT_REF=https://github.com/stellar/soroban-cli.git#main \
RUST_TOOLCHAIN_VERSION=stable \
RS_XDR_GIT_REF=v21.0.1 \
QUICKSTART_GIT_REF=https://github.com/stellar/quickstart.git#master \
JS_STELLAR_SDK_NPM_VERSION=11.3.0 \
PROTOCOL_VERSION_DEFAULT=21 \
build
$ docker run --rm -t --name e2e_test stellar/system-test:dev \
--VerboseOutput true \
--TestFilter "^TestDappDevelop$/^.*$" \
--SorobanExamplesGitHash 782458d31395b0191ac40c9572ac53f13f573aa3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove use of the soroban config commands from tests.
Why
The soroban config commands have been deprecated for a while and replaced with other commands. Soon the deprecated commands will be deleted.
Related to: