Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Test: as a DApp developer, I'm able to deploy asset contract and mint/xfer/burn. #22

Open
sreuland opened this issue Feb 2, 2023 · 2 comments

Comments

@sreuland
Copy link
Contributor

sreuland commented Feb 2, 2023

What problem does your feature solve?

no automated coverage of a dapp interacting with asset contacts

What would you like to see?

new automated test that exercises e2e coverage case:

as a DApp developer, I'm able to deploy an asset contract for my asset and perform mint/burn/xfer with my asset contract between accounts and other contracts using javascript sdk.

Test should be packaged in existing system-test docker and as a go test which asserts on configurable versions of the necessary stack: cli, rpc, soroban-example contracts, and network. This scaffolding is already present in the system-test framework.

Ideally, the existing integration tests for soroban asset contracts(SAC) in monorepo could be deprecated(removed) once this is done in system-test as it will be performing duplicative coverage.

What alternatives are there?

rely on the existing integration tests for asset contracts internal to monorepo - https://github.com/stellar/go/blob/soroban-xdr-next/services/horizon/internal/integration/sac_test.go for limited coverage of SAC, the tests do not use javascript.

@sreuland sreuland changed the title New test: as a DApp developer, I'm able to deploy my asset as an asset contract and mint/xfer/burn. New test: as a DApp developer, I'm able to deploy asset contract and mint/xfer/burn. Feb 2, 2023
@sreuland sreuland added this to the Soroban Pubnet Release milestone Sep 27, 2023
@sreuland sreuland changed the title New test: as a DApp developer, I'm able to deploy asset contract and mint/xfer/burn. System Test: as a DApp developer, I'm able to deploy asset contract and mint/xfer/burn. Sep 27, 2023
@sydneynotthecity
Copy link

@sreuland to evaluate if we will move tests to integration tests in soroban-tools as part of CLI

@sreuland
Copy link
Contributor Author

sreuland commented Oct 3, 2023

soroban cli tool tests are defined separately as integration tests in soroban-tools repo - stellar/stellar-cli#995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants