Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: re-enable SAC testing for authnext support #4757

Closed
tsachiherman opened this issue Feb 2, 2023 · 6 comments
Closed

tests: re-enable SAC testing for authnext support #4757

tsachiherman opened this issue Feb 2, 2023 · 6 comments
Assignees

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Feb 2, 2023

this ticket is a followup on stellar/stellar-cli#347.

during the xdr updates, we found that the unit testing around the SAC were failing due to changes in the contract.
The contract need to be updated for the test to pass. There might be other culprits that were missed before.

related PR : stellar/rs-soroban-env#645

this issue is part of the authNext efforts, which are covered in stellar/stellar-cli#346

@2opremio
Copy link
Contributor

2opremio commented Feb 2, 2023

In order to fix this the soroban examples repo needs to be updated with a new token contract spec

@sreuland
Copy link
Contributor

sreuland commented Feb 2, 2023

@2opremio @tsachiherman , i'm getting up to speed, here's what I think actions are needed:

  • get new rs-soroban-sdk that includes auth-next in rs-soroban-env - in pr #848
  • copy https://github.com/2opremio/soroban-examples/tree/sac_test to soroban/examples/single_asset
  • update soroban-examples deps to latest rs-soroban-sdk with auth-next
  • obtain new soroban token spec wasm that is auth compliant, copy it to soroban-examples/soroban_token_spec.wasm
  • compile soroban-examples/single_asset to .wasm and copy that to test fixture that SAC tests use in monorepo
  • get new debian pkg of stellar-core~soroban that includes latest rs-soroban-env, use that in monorepo
  • re-enable sac tests in monorepo, should pass now

@tsachiherman
Copy link
Contributor Author

yes, all of these looks right. I don't know if there would be more once we're done with these.

@sreuland
Copy link
Contributor

sreuland commented Feb 2, 2023

after looking at the asset contract tests in monorepo, I think is example of where system-test can be used instead, i.e. those asset contract tests, could be done as a dapp feature test in system-test where same functionality is driven by external component such as soroban cli tool for superset of e2e range, so captured that as additional feature request for later in system-test, at which point they could be deprecated here:

stellar/system-test#22

@tsachiherman
Copy link
Contributor Author

@sreuland I agree that the system tests would provide good coverage for these features, however, depending on these prevent us from pinpointing a potential bug in horizon. i.e. a potential bug in the CLI would prevent us from testing horizon. That's not that great. I do agree that we should cross-level and skip-level testing ( i.e. the ticket that you've created is valid and should be completed )

sreuland added a commit to sreuland/go that referenced this issue Feb 6, 2023
sreuland added a commit to sreuland/go that referenced this issue Feb 6, 2023
sreuland added a commit to sreuland/go that referenced this issue Feb 7, 2023
sreuland added a commit to sreuland/go that referenced this issue Feb 7, 2023
@sreuland sreuland moved this from In Progress to Needs Review in Platform Scrum Feb 9, 2023
@sreuland
Copy link
Contributor

sreuland commented Feb 9, 2023

merged pr #4759

@sreuland sreuland closed this as completed Feb 9, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants