-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: re-enable SAC testing for authnext support #4757
Comments
In order to fix this the soroban examples repo needs to be updated with a new token contract spec |
@2opremio @tsachiherman , i'm getting up to speed, here's what I think actions are needed:
|
yes, all of these looks right. I don't know if there would be more once we're done with these. |
after looking at the asset contract tests in monorepo, I think is example of where system-test can be used instead, i.e. those asset contract tests, could be done as a dapp feature test in system-test where same functionality is driven by external component such as soroban cli tool for superset of e2e range, so captured that as additional feature request for later in system-test, at which point they could be deprecated here: |
@sreuland I agree that the system tests would provide good coverage for these features, however, depending on these prevent us from pinpointing a potential bug in horizon. i.e. a potential bug in the CLI would prevent us from testing horizon. That's not that great. I do agree that we should cross-level and skip-level testing ( i.e. the ticket that you've created is valid and should be completed ) |
…ns for auth next support
…agging and recompiled contracts
merged pr #4759 |
this ticket is a followup on stellar/stellar-cli#347.
during the xdr updates, we found that the unit testing around the SAC were failing due to changes in the contract.
The contract need to be updated for the test to pass. There might be other culprits that were missed before.
related PR : stellar/rs-soroban-env#645
this issue is part of the authNext efforts, which are covered in stellar/stellar-cli#346
The text was updated successfully, but these errors were encountered: