-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/sign with lab #1579
Closed
Closed
Feat/sign with lab #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
feat/sign_with_lab
branch
from
September 4, 2024 18:24
65086b4
to
800e802
Compare
Added some comments in Aha labs PR, thanks @elizabethengelman ! |
5 tasks
elizabethengelman
force-pushed
the
feat/sign_with_lab
branch
from
September 11, 2024 19:54
abb0db6
to
b6a1878
Compare
closing this in favor of #1604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based on
#1406#1590, I also opened a PR against that branch directly in the AhaLabs org so that it is easier to see the diff: AhaLabs#25.Companion Lab PR: stellar/laboratory#987
Todo:
/transaction/cli-sign
What
Closes #1428
This PR adds the ability to sign a tx via lab, by opening lab in the browser with the xdr prefilled in the Lab UI.
To test, on this branch, run:
(
stellar contract deploy --wasm target/wasm32-unknown-unknown/test-wasms/test_hello_world.wasm --build-only --network testnet --source testnet-alice
)Why
This will allow for another way for users to sign their tx.
Known limitations
Based on discussions during our weekly check-in, this PR is the first step in implementing this feature. For now, when the user adds the
--sign-with-lab
flag, the CLI will send the transaction's xdr to lab via a query param, and then will print out the xdr to the stdout.In future iterations, we may want to send the signed tx xdr back to the command line, but for now the intention is to have the user either:
a. send the transaction from lab
b. manually copy the signed xdr from Lab, and paste it back in the command line to use with the cli
Instead of having the flag be
--sign-with-lab
, what if we change it to--sign-externally
? This would open us up to allow a user to pass in any URL that acceptsxdr
andnetworkPasshrase
as query params. 🤔