-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add other ledger test emulators #1321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
add-other-ledger-test-emulators
branch
2 times, most recently
from
May 8, 2024 19:42
436e915
to
6e9e58b
Compare
2 tasks
elizabethengelman
force-pushed
the
add-other-ledger-test-emulators
branch
from
May 30, 2024 22:02
7a82e4c
to
4c5d3b6
Compare
elizabethengelman
force-pushed
the
add-other-ledger-test-emulators
branch
3 times, most recently
from
June 5, 2024 15:05
cc82ff3
to
109d7a6
Compare
elizabethengelman
force-pushed
the
add-other-ledger-test-emulators
branch
from
June 5, 2024 19:03
109d7a6
to
93afad1
Compare
chadoh
reviewed
Jun 13, 2024
chadoh
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive and v helpful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1343
What
Adds the nanox and nanosp elf files.
Why
These were added for testing, so that we can run some integration-like tests again a Ledger emulator (called Speculos) to make sure that our ledger signer works with different Ledger device models.
Known limitations
[TODO or N/A]