Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other ledger test emulators #1321

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented May 8, 2024

This is based on #1343

What

Adds the nanox and nanosp elf files.

Why

These were added for testing, so that we can run some integration-like tests again a Ledger emulator (called Speculos) to make sure that our ledger signer works with different Ledger device models.

Known limitations

[TODO or N/A]

@elizabethengelman elizabethengelman force-pushed the add-other-ledger-test-emulators branch 2 times, most recently from 436e915 to 6e9e58b Compare May 8, 2024 19:42
@elizabethengelman elizabethengelman mentioned this pull request May 9, 2024
5 tasks
@elizabethengelman elizabethengelman marked this pull request as ready for review June 3, 2024 20:29
@elizabethengelman elizabethengelman force-pushed the add-other-ledger-test-emulators branch 3 times, most recently from cc82ff3 to 109d7a6 Compare June 5, 2024 15:05
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive and v helpful!

@chadoh chadoh enabled auto-merge June 13, 2024 14:45
@chadoh chadoh merged commit 035b793 into stellar:main Jun 13, 2024
23 of 24 checks passed
@chadoh chadoh deleted the add-other-ledger-test-emulators branch June 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants