This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Only apply rules if they exist #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to the null check of rules to see if any rules exist.
This helps since in the case that a policy is stored in config with null rules, since when when it is deserialized, rules will not be null in memory due to instantiation as empty in the default ctor.
Therefore, IP/ClientKey/Endpoint will be checked even if there are no rules.
This could be problematic since if GetRequestIdentity is overridden and IP isn't set explicitly (since from a policy perspective there are no rules or whitelists connected to IP) an exception will be thrown while parsing it.
Finally, this is a small perf boost, since if there are no rules, none of the rule related code is run.