Skip to content

Commit

Permalink
feat: make probes configurable via helm-chart
Browse files Browse the repository at this point in the history
  • Loading branch information
@ReuDa
ReuDa committed Nov 21, 2023
1 parent 9014d34 commit 0096389
Show file tree
Hide file tree
Showing 4 changed files with 117 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/steadybit-extension-istio/Chart.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: steadybit-extension-istio
description: Steadybit Istio extension Helm chart for Kubernetes.
version: 1.0.22
version: 1.0.23
appVersion: latest
home: https://www.steadybit.com/
icon: https://steadybit-website-assets.s3.amazonaws.com/logo-symbol-transparent.png
Expand Down
10 changes: 10 additions & 0 deletions charts/steadybit-extension-istio/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,20 @@ spec:
volumeMounts:
{{- include "extensionlib.deployment.volumeMounts" (list .) | nindent 12 }}
livenessProbe:
initialDelaySeconds: {{ .Values.probes.liveness.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.liveness.periodSeconds }}
timeoutSeconds: {{ .Values.probes.liveness.timeoutSeconds }}
successThreshold: {{ .Values.probes.liveness.successThreshold }}
failureThreshold: {{ .Values.probes.liveness.failureThreshold }}
httpGet:
path: /health/liveness
port: 8081
readinessProbe:
initialDelaySeconds: {{ .Values.probes.readiness.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.readiness.periodSeconds }}
timeoutSeconds: {{ .Values.probes.readiness.timeoutSeconds }}
successThreshold: {{ .Values.probes.readiness.successThreshold }}
failureThreshold: {{ .Values.probes.readiness.failureThreshold }}
httpGet:
path: /health/readiness
port: 8081
Expand Down
90 changes: 90 additions & 0 deletions charts/steadybit-extension-istio/tests/__snapshot__/deployment_test.yaml.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,24 @@ manifest should match snapshot using podAnnotations and Labels:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -103,14 +113,24 @@ manifest should match snapshot with TLS:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -180,14 +200,24 @@ manifest should match snapshot with extra env vars:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -245,14 +275,24 @@ manifest should match snapshot with extra labels:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -314,14 +354,24 @@ manifest should match snapshot with mutual TLS:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -397,14 +447,24 @@ manifest should match snapshot with mutual TLS using containerPaths:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -460,14 +520,24 @@ manifest should match snapshot with podSecurityContext:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -525,14 +595,24 @@ manifest should match snapshot with priority class:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -589,14 +669,24 @@ manifest should match snapshot without TLS:
image: ghcr.io/steadybit/extension-istio:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8081
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down
16 changes: 16 additions & 0 deletions charts/steadybit-extension-istio/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,22 @@ logging:
# logging.format -- The format of the log entries. One of text, json
format: text

probes:
# probes.readiness.* -- Configuration of the Kubernetes readiness probe
readiness:
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
# probes.liveness.* -- Configuration of the Kubernetes liveness probe
liveness:
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 5
successThreshold: 1

resources:
requests:
# resources.requests.memory -- The minimal amount of memory needed
Expand Down

0 comments on commit 0096389

Please sign in to comment.