Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for stats/base/dists/binomial/cdf #3463

Closed
wants to merge 20 commits into from

Conversation

AadishJ
Copy link

@AadishJ AadishJ commented Dec 11, 2024

Resolves #3448.

Description

This pull request adds the functionality of binomial cdf

This pull request:

  • Added all the code related to binomial cdf functionality

Related Issues

No

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter Planeshifter changed the title [RFC]: Add implementations for @stdlib/stats/base/dists/binomial/cdf [RFC]: Add implementations for stats/base/dists/binomial/cdf Dec 11, 2024
@AadishJ
Copy link
Author

AadishJ commented Dec 11, 2024

Hey my code is passing this make TESTS_FILTER="./@stdlib/stats/base/dists/binomial/cdf/." test but is failing here can you please guide me??

@kgryte kgryte changed the title [RFC]: Add implementations for stats/base/dists/binomial/cdf feat: add C implementation for stats/base/dists/binomial/cdf Dec 12, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 12, 2024
@AadishJ
Copy link
Author

AadishJ commented Dec 12, 2024

the tests are failing but the error is really small how should i make it more accurate?

@AadishJ AadishJ requested a review from kgryte December 13, 2024 07:55
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 13, 2024
@AadishJ AadishJ closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/binomial/cdf
3 participants